ash/system/locale/locale_notification_controller.cc - Issue 684253002: Provide default implementations for NotificationDelegate methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/locale/locale_notification_controller.cc

Issue 684253002: Provide default implementations for NotificationDelegate methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/chromeos/screen_security/screen_tray_item.cc ('k') | chrome/browser/background/background_contents_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/locale/locale_notification_controller.cc

diff --git a/ash/system/locale/locale_notification_controller.cc b/ash/system/locale/locale_notification_controller.cc

index 63a4210591d4c872f84c340ee91e44c3ae9bcc38..20351adf8697e847ed5dcc64eb6ce91c9425d894 100644

--- a/ash/system/locale/locale_notification_controller.cc

+++ b/ash/system/locale/locale_notification_controller.cc

@@ -32,8 +32,6 @@ class LocaleNotificationDelegate : public message_center::NotificationDelegate {

~LocaleNotificationDelegate() override;

// message_center::NotificationDelegate overrides:

- void Display() override;

- void Error() override;

void Close(bool by_user) override;

bool HasClickedListener() override;

void Click() override;

@@ -54,12 +52,6 @@ LocaleNotificationDelegate::LocaleNotificationDelegate(

LocaleNotificationDelegate::~LocaleNotificationDelegate() {

}

-void LocaleNotificationDelegate::Display() {

-void LocaleNotificationDelegate::Error() {

void LocaleNotificationDelegate::Close(bool by_user) {

delegate_->AcceptLocaleChange();

}