chrome/browser/notifications/extension_welcome_notification.cc - Issue 684253002: Provide default implementations for NotificationDelegate methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification.cc

Issue 684253002: Provide default implementations for NotificationDelegate methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/privet_notifications.cc ('k') | chrome/browser/notifications/extension_welcome_notification_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification.cc b/chrome/browser/notifications/extension_welcome_notification.cc

index c061dd8a877ccdc068d7a9a5524adf925b0ca540..335ebb8fc3c53e6363c39d1ba8a762836ec6ff7a 100644

--- a/chrome/browser/notifications/extension_welcome_notification.cc

+++ b/chrome/browser/notifications/extension_welcome_notification.cc

@@ -47,9 +47,6 @@ class NotificationCallbacks

}

// Overridden from NotificationDelegate:

- void Display() override {}

- void Error() override {}

void Close(bool by_user) override {

if (by_user) {

// Setting the preference here may cause the notification erasing

@@ -60,7 +57,6 @@ class NotificationCallbacks

}

- void Click() override {}

void ButtonClick(int index) override {

if (index == 0) {

OpenNotificationLearnMoreTab();