chrome/browser/background/background_contents_service.cc - Issue 684253002: Provide default implementations for NotificationDelegate methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 684253002: Provide default implementations for NotificationDelegate methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/locale/locale_notification_controller.cc ('k') | chrome/browser/chromeos/file_system_provider/notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents_service.cc

diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc

index 016e429db82292831eda8e22c5d1e26f062e772f..3b87006e1d76365b6d5286d62ce719ca6ab42ba2 100644

--- a/chrome/browser/background/background_contents_service.cc

+++ b/chrome/browser/background/background_contents_service.cc

@@ -104,12 +104,6 @@ class CrashNotificationDelegate : public NotificationDelegate {

extension_id_(extension->id()) {

}

- void Display() override {}

- void Error() override {}

- void Close(bool by_user) override {}

void Click() override {

// http://crbug.com/247790 involves a crash notification balloon being

// clicked while the extension isn't in the TERMINATED state. In that case,