Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Issue 683993002: Revert of Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
index 4b129afa7c3cdffd4bfca86eb47e4d6e6e0f3590..368929dc133a5fe6ba50f3de16f79c0a05a9c954 100644
--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
@@ -161,16 +161,16 @@
}
bool ScrollbarTest::IsScrollbarVisible() {
+ ExtensionInstallPrompt::ShowParams show_params(web_contents());
ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView(
- profile(),
- web_contents(),
+ show_params.profile,
+ show_params.parent_web_contents,
delegate(),
prompt());
// Create the modal view around the install dialog view.
views::Widget* modal =
- CreateBrowserModalDialogViews(dialog,
- web_contents()->GetTopLevelNativeWindow());
+ CreateBrowserModalDialogViews(dialog, show_params.parent_window);
modal->Show();
content::RunAllBlockingPoolTasksUntilIdle();
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698