Issue 681963002: Remove heap/*.cpp files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 681963002: Remove heap/*.cpp files (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove heap/*.cpp files Nothing in heap/ is called anymore, but it still has its claws deep into many of the base classes for the rest of Sky, so I've left the (largely unmodified) headers for now. We'll trim the headers further in later patches. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/004fbb6b111db65e4b9784ee35cfbd53244bc0a1

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3966 lines)			Patch
M	sky/engine/bindings/core/v8/V8Binding.h	View	1 chunk	+2 lines, -14 lines	0 comments	Download
M	sky/engine/bindings/scripts/v8_callback_interface.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/css/resolver/MatchedPropertiesCache.h	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/core/css/resolver/MatchedPropertiesCache.cpp	View	6 chunks	+0 lines, -37 lines	0 comments	Download
M	sky/engine/core/loader/ImageLoader.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	sky/engine/core/loader/ImageLoader.cpp	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	sky/engine/platform/Supplementable.h	View	2 chunks	+0 lines, -34 lines	0 comments	Download
M	sky/engine/platform/heap/BUILD.gn	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/platform/heap/Handle.h	View	5 chunks	+0 lines, -41 lines	0 comments	Download
D	sky/engine/platform/heap/Handle.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	sky/engine/platform/heap/Heap.h	View	2 chunks	+4 lines, -7 lines	0 comments	Download
D	sky/engine/platform/heap/Heap.cpp	View	1 chunk	+0 lines, -2625 lines	0 comments	Download
D	sky/engine/platform/heap/HeapLinkedStack.h	View	1 chunk	+0 lines, -115 lines	0 comments	Download
M	sky/engine/platform/heap/ThreadState.h	View	4 chunks	+1 line, -89 lines	0 comments	Download
D	sky/engine/platform/heap/ThreadState.cpp	View	1 chunk	+0 lines, -898 lines	0 comments	Download
D	sky/engine/platform/heap/Visitor.cpp	View	1 chunk	+0 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eseidel

6 years, 1 month ago (2014-10-28 00:13:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
004fbb6b111db65e4b9784ee35cfbd53244bc0a1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages