Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(636)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/engine/platform/heap/BUILD.gn
Issue
681963002
:
Remove heap/*.cpp files (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set:
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/engine/bindings/core/v8/V8Binding.h
sky/engine/bindings/scripts/v8_callback_interface.py
sky/engine/core/css/resolver/MatchedPropertiesCache.h
sky/engine/core/css/resolver/MatchedPropertiesCache.cpp
sky/engine/core/loader/ImageLoader.h
sky/engine/core/loader/ImageLoader.cpp
sky/engine/platform/Supplementable.h
sky/engine/platform/heap/BUILD.gn
sky/engine/platform/heap/Handle.h
sky/engine/platform/heap/Handle.cpp
sky/engine/platform/heap/Heap.h
sky/engine/platform/heap/Heap.cpp
sky/engine/platform/heap/HeapLinkedStack.h
sky/engine/platform/heap/ThreadState.h
sky/engine/platform/heap/ThreadState.cpp
sky/engine/platform/heap/Visitor.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« sky/engine/platform/Supplementable.h
('k') |
sky/engine/platform/heap/Handle.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.
1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
3 # found in the LICENSE file.
4
4
5 visibility = ["//sky/engine/*"]
5 visibility = ["//sky/engine/*"]
6
6
7 source_set("heap") {
7 source_set("heap") {
8 sources = [
8 sources = [
9 "AddressSanitizer.h",
9 "AddressSanitizer.h",
10
"Handle.cpp",
11 "Handle.h",
10 "Handle.h",
12
"Heap.cpp",
13
"Heap.h",
14
"ThreadState.cpp",
15 "ThreadState.h",
11 "ThreadState.h",
16
"Visitor.cpp",
17 "Visitor.h",
12 "Visitor.h",
18 ]
13 ]
19
14
20 configs += [ "//sky/engine:config" ]
15 configs += [ "//sky/engine:config" ]
21
16
22 deps = [
17 deps = [
23 "//third_party/icu",
18 "//third_party/icu",
24 ]
19 ]
25 }
20 }
OLD
NEW
« no previous file with comments
|
« sky/engine/platform/Supplementable.h
('k') |
sky/engine/platform/heap/Handle.h »
('j') |
no next file with comments »
Issue 681963002: Remove heap/*.cpp files (Closed)
Created 6 years, 1 month ago by eseidel
Modified 6 years, 1 month ago
Reviewers: abarth-chromium
Base URL: git@github.com:domokit/mojo.git@master
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
