sky/engine/bindings/scripts/v8_callback_interface.py - Issue 681963002: Remove heap/*.cpp files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/v8_callback_interface.py

Issue 681963002: Remove heap/*.cpp files (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/v8_callback_interface.py

diff --git a/sky/engine/bindings/scripts/v8_callback_interface.py b/sky/engine/bindings/scripts/v8_callback_interface.py

index 865d4e93e98aece46befe7781787609f543a7c29..9e30e888ec0def05abd3566ce52bc76f2abb3c96 100644

--- a/sky/engine/bindings/scripts/v8_callback_interface.py

+++ b/sky/engine/bindings/scripts/v8_callback_interface.py

@@ -63,7 +63,7 @@ def cpp_type(idl_type):

return 'void'

# Callbacks use raw pointers, so raw_type=True

raw_cpp_type = idl_type.cpp_type_args(raw_type=True)

- if raw_cpp_type.startswith(('Vector', 'HeapVector', 'Vector')):

+ if raw_cpp_type.startswith(('Vector', 'Vector')):

return 'const %s&' % raw_cpp_type

return raw_cpp_type