Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1842)

Unified Diff: sky/engine/core/loader/ImageLoader.h

Issue 681963002: Remove heap/*.cpp files (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/resolver/MatchedPropertiesCache.cpp ('k') | sky/engine/core/loader/ImageLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/loader/ImageLoader.h
diff --git a/sky/engine/core/loader/ImageLoader.h b/sky/engine/core/loader/ImageLoader.h
index 049c138c8d621713b07caafb54a54bdc2be4c360..ef5951bbc82b8b5e0da4ff0af6828b0523022985 100644
--- a/sky/engine/core/loader/ImageLoader.h
+++ b/sky/engine/core/loader/ImageLoader.h
@@ -144,31 +144,8 @@ private:
RawPtr<Element> m_element;
ResourcePtr<ImageResource> m_image;
- // FIXME: Oilpan: We might be able to remove this Persistent hack when
- // ImageResourceClient is traceable.
- GC_PLUGIN_IGNORE("http://crbug.com/383741")
RefPtr<Element> m_keepAlive;
-#if ENABLE(OILPAN)
- class ImageLoaderClientRemover {
- public:
- ImageLoaderClientRemover(ImageLoader& loader, ImageLoaderClient& client) : m_loader(loader), m_client(client) { }
- ~ImageLoaderClientRemover();
-
- private:
- ImageLoader& m_loader;
- ImageLoaderClient& m_client;
- };
- friend class ImageLoaderClientRemover;
- // Oilpan: This ImageLoader object must outlive its clients because they
- // need to call ImageLoader::willRemoveClient before they
- // die. Non-Persistent HeapHashMap doesn't work well because weak processing
- // for HeapHashMap is not triggered when both of ImageLoader and
- // ImageLoaderClient are unreachable.
- GC_PLUGIN_IGNORE("http://crbug.com/383742")
- PersistentHeapHashMap<WeakMember<ImageLoaderClient>, OwnPtr<ImageLoaderClientRemover> > m_clients;
-#else
HashSet<ImageLoaderClient*> m_clients;
-#endif
Timer<ImageLoader> m_derefElementTimer;
AtomicString m_failedLoadURL;
WeakPtr<Task> m_pendingTask; // owned by Microtask
« no previous file with comments | « sky/engine/core/css/resolver/MatchedPropertiesCache.cpp ('k') | sky/engine/core/loader/ImageLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698