Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68173014: Have ElementTraversal::firstWithin() take a reference (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
adamk
CC:
blink-reviews, krit, aboxhall, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, pdr, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have ElementTraversal::firstWithin() take a reference Have ElementTraversal::firstWithin() take a reference instead of a pointer as its implementation expects the pointer to be non-null. This makes the code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -114 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/ElementTraversal.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 18 chunks +34 lines, -33 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCollection.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/page/FocusController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
Adam, for some reason I cannot reupload the patch at https://codereview.chromium.org/65303008/ that you already reviewed ...
7 years, 1 month ago (2013-11-13 20:58:55 UTC) #1
adamk
lgtm rs=me
7 years, 1 month ago (2013-11-13 21:04:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/68173014/1
7 years, 1 month ago (2013-11-13 21:06:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/68173014/1
7 years, 1 month ago (2013-11-14 01:07:25 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 02:58:44 UTC) #5
Message was sent while issue was closed. 
Change committed as 161969

Powered by Google App Engine
This is Rietveld 408576698