Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: Source/core/css/StyleInvalidationAnalysis.cpp

Issue 68173014: Have ElementTraversal::firstWithin() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/StyleInvalidationAnalysis.h ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 if (classScopes.isEmpty() || !element->hasClass()) 197 if (classScopes.isEmpty() || !element->hasClass())
198 return false; 198 return false;
199 const SpaceSplitString& classNames = element->classNames(); 199 const SpaceSplitString& classNames = element->classNames();
200 for (unsigned i = 0; i < classNames.size(); ++i) { 200 for (unsigned i = 0; i < classNames.size(); ++i) {
201 if (classScopes.contains(classNames[i].impl())) 201 if (classScopes.contains(classNames[i].impl()))
202 return true; 202 return true;
203 } 203 }
204 return false; 204 return false;
205 } 205 }
206 206
207 void StyleInvalidationAnalysis::invalidateStyle(Document* document) 207 void StyleInvalidationAnalysis::invalidateStyle(Document& document)
208 { 208 {
209 ASSERT(!m_dirtiesAllStyle); 209 ASSERT(!m_dirtiesAllStyle);
210 210
211 if (!m_scopingNodes.isEmpty()) { 211 if (!m_scopingNodes.isEmpty()) {
212 for (unsigned i = 0; i < m_scopingNodes.size(); ++i) 212 for (unsigned i = 0; i < m_scopingNodes.size(); ++i)
213 m_scopingNodes.at(i)->setNeedsStyleRecalc(); 213 m_scopingNodes.at(i)->setNeedsStyleRecalc();
214 } 214 }
215 215
216 if (m_idScopes.isEmpty() && m_classScopes.isEmpty()) 216 if (m_idScopes.isEmpty() && m_classScopes.isEmpty())
217 return; 217 return;
218 Element* element = ElementTraversal::firstWithin(document); 218 Element* element = ElementTraversal::firstWithin(document);
219 while (element) { 219 while (element) {
220 if (elementMatchesSelectorScopes(element, m_idScopes, m_classScopes)) { 220 if (elementMatchesSelectorScopes(element, m_idScopes, m_classScopes)) {
221 element->setNeedsStyleRecalc(); 221 element->setNeedsStyleRecalc();
222 // The whole subtree is now invalidated, we can skip to the next sib ling. 222 // The whole subtree is now invalidated, we can skip to the next sib ling.
223 element = ElementTraversal::nextSkippingChildren(*element); 223 element = ElementTraversal::nextSkippingChildren(*element);
224 continue; 224 continue;
225 } 225 }
226 element = ElementTraversal::next(*element); 226 element = ElementTraversal::next(*element);
227 } 227 }
228 } 228 }
229 229
230 } 230 }
OLDNEW
« no previous file with comments | « Source/core/css/StyleInvalidationAnalysis.h ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698