Source/core/dom/LiveNodeList.h - Issue 68173014: Have ElementTraversal::firstWithin() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/LiveNodeList.h

Issue 68173014: Have ElementTraversal::firstWithin() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/LiveNodeList.h

diff --git a/Source/core/dom/LiveNodeList.h b/Source/core/dom/LiveNodeList.h

index 0756b388873aad4a2a6483fd064a09cf740a6602..2145b245f9ee85166540f90302f42a95b2ed0c70 100644

--- a/Source/core/dom/LiveNodeList.h

+++ b/Source/core/dom/LiveNodeList.h

@@ -137,7 +137,7 @@ protected:

private:

Node* itemBeforeOrAfterCachedItem(unsigned offset, ContainerNode* root) const;

Node* traverseChildNodeListForwardToOffset(unsigned offset, Node* currentNode, unsigned& currentOffset) const;

- Element* traverseLiveNodeListFirstElement(ContainerNode* root) const;

+ Element* traverseLiveNodeListFirstElement(ContainerNode& root) const;

Element* traverseLiveNodeListForwardToOffset(unsigned offset, Element& currentElement, unsigned& currentOffset, ContainerNode* root) const;

bool isLastItemCloserThanLastOrCachedItem(unsigned offset) const;

bool isFirstItemCloserThanCachedItem(unsigned offset) const;

« no previous file with comments | « Source/core/dom/ElementTraversal.h ('k') | Source/core/dom/SelectorQuery.h » ('j') | no next file with comments »