Source/core/page/FocusController.h - Issue 68173014: Have ElementTraversal::firstWithin() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FocusController.h

Issue 68173014: Have ElementTraversal::firstWithin() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/FocusController.h

diff --git a/Source/core/page/FocusController.h b/Source/core/page/FocusController.h

index 8abdb66343222dd058111cd3933a52a31287b6b9..38069eb4919191ed936583e4ef1444f7f23e06df 100644

--- a/Source/core/page/FocusController.h

+++ b/Source/core/page/FocusController.h

@@ -112,7 +112,7 @@ private:

Node* findNodeWithExactTabIndex(Node* start, int tabIndex, FocusDirection);

bool advanceFocusDirectionallyInContainer(Node* container, const LayoutRect& startingRect, FocusDirection);

- void findFocusCandidateInContainer(Node* container, const LayoutRect& startingRect, FocusDirection, FocusCandidate& closest);

+ void findFocusCandidateInContainer(Node& container, const LayoutRect& startingRect, FocusDirection, FocusCandidate& closest);

Page* m_page;

RefPtr<Frame> m_focusedFrame;

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/page/FocusController.cpp » ('j') | no next file with comments »