Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 679863002: Revert "Prepare blink to unify definitions of load completion" (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)
Modified:
6 years, 1 month ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert "Prepare blink to unify definitions of load completion" This reverts commit c11d2adcd5204907f2541979ad3c0140756f66de. Lots of Chromium bots are dying in RSS tests, and this change (which was explicitly called out as a possible troublemaker) was in the changelists when it started. More details at https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/j60j0FXl7mI TBR=japhet@chromium.org,dcheng@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=426520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -395 lines) Patch
M LayoutTests/css3/masking/mask-repeat-space-content.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/css3/masking/mask-repeat-space-content-expected.html View 2 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/css3/masking/mask-repeat-space-padding-expected.html View 2 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/editing/execCommand/window-open-insert-list-crash.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/editing/undo/crash-redo-with-iframes.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Document/document-close-nested-iframe-load.html View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLHeadElement/head-link-style-href-check.html View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/fast/dom/ImageDocument-image-deletion.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/ImageDocument-image-deletion-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/document-write.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/StyleSheet/css-insert-import-rule-to-shadow-stylesheets.html View 1 chunk +12 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-open-no-multiple-windows-from-iframe.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/css-cached-import-rule.html View 1 chunk +5 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/css-insert-import-rule.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/adopt-node-with-shadow-root.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/import-rule-in-shadow-tree-needs-document-style-recalc.html View 2 chunks +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-tree-listener-clearance.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/mouseenter-mouseleave-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/popup-allowed-from-gesture-initiated-form-submit.html View 1 chunk +4 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/scroll-event-handler-count.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/button-in-forms-collection.html View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/button-in-forms-collection-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/frames/document-write-in-iframe-onload-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/document-write-in-iframe-onload-3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/frameset-dynamic-resize.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/frames/location-put-after-removal-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/html/imports/import-destroy-stress.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html View 2 chunks +1 line, -5 lines 0 comments Download
M LayoutTests/fast/loader/external-script-URL-location.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/loader/open-in-srcdoc-unload.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/resources/document-destruction-within-unload-iframe.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/resources/external-script-URL-location.js View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/loader/stateobjects/state-attribute-only-one-deserialization.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/loader/stateobjects/state-attribute-popstate-event.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/loader/subframe-removes-itself-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/parser/adoption-agency-crash-03.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/document-close-nested-iframe-load.html View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/parser/document-open-in-unload.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/parser/document-open-in-unload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/document-write-ignores-later-network-bytes.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/document-write-onload-nesting.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/iframe-onload-document-close-with-external-script.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/iframe-onload-document-close-with-external-script-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/iframe-onload-document-close-with-external-script-3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/webfont-synthetic-bold.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/tokenizer/resources/write-external-script-open.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/tokenizer/write-external-script-open.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/cache/cancel-multiple-post-xhrs-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/fouc/scroll-left-while-loading.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/doc-write-before-end.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/local/file-url-sent-as-referer.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash.html View 2 chunks +9 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/misc/window-dot-stop-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/http/tests/multipart/invalid-image-data.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/multipart/invalid-image-data-standalone-expected.txt View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/navigation/go-back-to-error-page.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/navigation/go-back-to-error-page-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/navigation/lockedhistory-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cookies/base-about-blank.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-call.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-custom.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-frames.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-name-getter.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/html5-import-safe-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/svg/change-id-with-pending-resources.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/svg/tref-adoptNode-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html View 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/reentrant-cancel.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/navigation-target.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/send-on-abort.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/platform/linux/http/tests/multipart/invalid-image-data-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/http/tests/multipart/invalid-image-data-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/platform/win-xp/http/tests/multipart/invalid-image-data-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/http/tests/multipart/invalid-image-data-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/platform/win/http/tests/multipart/invalid-image-data-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/win/http/tests/multipart/invalid-image-data-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/security/block-test-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download
M LayoutTests/security/block-test-no-port-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/bug79798.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/draw-image-crash.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/resources/linkingCircle-f.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/complex-svgView-specification.html View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/svg/wicd/test-rightsizing-a.xhtml View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/svg/wicd/test-rightsizing-b.xhtml View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/svg/wicd/test-scalable-background-image1.xhtml View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/svg/wicd/test-scalable-background-image2.xhtml View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/webaudio/scriptprocessornode-rewrap.html View 2 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/webaudio/scriptprocessornode-upmix2-8channel-input.html View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/fetch/Resource.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 7 chunks +7 lines, -14 lines 0 comments Download
M Source/core/fetch/ResourceLoaderHost.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 5 chunks +7 lines, -17 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 8 chunks +7 lines, -15 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679863002/1
6 years, 1 month ago (2014-10-25 20:26:10 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 20:28:40 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184408

Powered by Google App Engine
This is Rietveld 408576698