Source/core/loader/FrameFetchContext.cpp - Issue 679863002: Revert "Prepare blink to unify definitions of load completion"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameFetchContext.cpp

Issue 679863002: Revert "Prepare blink to unify definitions of load completion" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameFetchContext.cpp

diff --git a/Source/core/loader/FrameFetchContext.cpp b/Source/core/loader/FrameFetchContext.cpp

index 313fab123cea3fd7fe5169d7dc54709d4f4c40c6..57d55d54c290cd031307eb37970ae7d6470dd4bc 100644

--- a/Source/core/loader/FrameFetchContext.cpp

+++ b/Source/core/loader/FrameFetchContext.cpp

@@ -186,7 +186,6 @@ void FrameFetchContext::dispatchDidFinishLoading(DocumentLoader* loader, unsigne

void FrameFetchContext::dispatchDidFail(DocumentLoader* loader, unsigned long identifier, const ResourceError& error, bool isInternalRequest)

{

m_frame->loader().progress().completeProgress(identifier);

- m_frame->loader().client()->dispatchDidFinishLoading(loader, identifier);

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ResourceFinish", "data", InspectorResourceFinishEvent::data(identifier, 0, true));

// FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeline migrates to tracing.

InspectorInstrumentation::didFailLoading(m_frame, identifier, error);

« no previous file with comments | « Source/core/fetch/ResourceLoaderHost.h ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »