LayoutTests/fast/frames/frameset-dynamic-resize.html - Issue 679863002: Revert "Prepare blink to unify definitions of load completion"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/frames/frameset-dynamic-resize.html

Issue 679863002: Revert "Prepare blink to unify definitions of load completion" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/frames/document-write-in-iframe-onload-3.html ('k') | LayoutTests/fast/frames/location-put-after-removal-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 This tests that we don't break dynamic frameset layouts.	3 This tests that we don't break dynamic frameset layouts.

4 https://code.google.com/p/chromium/issues/detail?id=266882.	4 https://code.google.com/p/chromium/issues/detail?id=266882.

5 Visually it should show a green 100x100 square.	5 Visually it should show a green 100x100 square.

6 -->	6 -->

7 <script>	7 <script>

8 if (window.testRunner) {	8 if (window.testRunner) {

9 testRunner.dumpAsText();	9 testRunner.dumpAsText();

10 // FIXME: Why is waitUntilDone needed? Shouldn't this body onload wait for the subframes?	10 // FIXME: Why is waitUntilDone needed? Shouldn't this body onload wait for the subframes?

11 testRunner.waitUntilDone();	11 testRunner.waitUntilDone();

12 }	12 }

13	13

14 function runTest() {	14 function runTest() {

15 var iframe = document.getElementById('target');	15 var iframe = document.getElementById('target');

16 iframe.offsetTop; // Make sure the iframe has already had a layout.	16 iframe.offsetTop; // Make sure the iframe has already had a layout.

17 iframe.style.height = '100px'; // Dynamically resize to 100 height.	17 iframe.style.height = '100px'; // Dynamically resize to 100 height.

18 // Check to make sure the inner frameset noticed the resize:	18 // Check to make sure the inner frameset noticed the resize:

19 var height = iframe.contentWindow.document.body.clientHeight;	19 var height = iframe.contentWindow.document.body.clientHeight;

20 if (height == 100)	20 if (height == 100)

21 document.write("PASS");	21 document.write("PASS");

22 else	22 else

23 document.write("FAIL, height should be 100, is: " + height);	23 document.write("FAIL, height should be 100, is: " + height);

24	24

25 document.close();

26 if (window.testRunner)	25 if (window.testRunner)

27 testRunner.notifyDone();	26 testRunner.notifyDone();

28 }	27 }

29 </script>	28 </script>

30 <iframe id="target" style="width: 100px; height: 1px; border: 0px" src="resource s/frameset-dynamic-resize-inner1.html" onload="runTest()"></iframe>	29 <iframe id="target" style="width: 100px; height: 1px; border: 0px" src="resource s/frameset-dynamic-resize-inner1.html" onload="runTest()"></iframe>

OLD	NEW