Source/web/tests/WebFrameTest.cpp - Issue 679863002: Revert "Prepare blink to unify definitions of load completion"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 679863002: Revert "Prepare blink to unify definitions of load completion" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 475e975a426182f0245fc01c62de28632c9dc9e2..d72a9e8c724bfed1f84c8e2a8b38f50ba4ca57bb 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -5328,7 +5328,7 @@ TEST_F(WebFrameTest, DidWriteToInitialDocumentBeforeModalDialog)

// initial empty document state of the state machine. We normally set a

// timer to notify the client.

newView->mainFrame()->executeScript(

- WebScriptSource("window.opener.document.write('Modified'); window.opener.document.close();"));

+ WebScriptSource("window.opener.document.write('Modified');"));

EXPECT_FALSE(webFrameClient.m_didAccessInitialDocument);

// Make sure that a modal dialog forces us to notify right away.

« no previous file with comments | « Source/web/tests/ActivityLoggerTest.cpp ('k') | no next file » | no next file with comments »