Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 678683005: Scissor rect on drawinfo (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@clip_to_target
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : wroking #

Patch Set 3 : feedback inc #

Total comments: 5

Patch Set 4 : feedback inc #

Patch Set 5 : feedback inc #

Total comments: 1

Patch Set 6 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -78 lines) Patch
M src/gpu/GrClipMaskManager.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 3 5 chunks +9 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 chunks +5 lines, -21 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 5 chunks +16 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 7 chunks +30 lines, -30 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
6 years, 1 month ago (2014-10-27 19:29:14 UTC) #2
bsalomon
https://codereview.chromium.org/678683005/diff/40001/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): https://codereview.chromium.org/678683005/diff/40001/src/gpu/GrGpu.cpp#newcode306 src/gpu/GrGpu.cpp:306: GrDrawState::AutoRestoreStencil arStencil; Here it's arStencil, but the param is ...
6 years, 1 month ago (2014-10-27 19:41:24 UTC) #3
joshualitt
feedback incorporated
6 years, 1 month ago (2014-10-27 20:56:20 UTC) #4
bsalomon
lgtm https://codereview.chromium.org/678683005/diff/80001/src/gpu/GrClipMaskManager.h File src/gpu/GrClipMaskManager.h (right): https://codereview.chromium.org/678683005/diff/80001/src/gpu/GrClipMaskManager.h#newcode55 src/gpu/GrClipMaskManager.h:55: const SkRect* devBounds, Time for an out struct?
6 years, 1 month ago (2014-10-27 21:00:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678683005/100001
6 years, 1 month ago (2014-10-27 21:42:37 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 21:51:08 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as 77b1307c1f5dac019575a6d431d5ce657370c4fb

Powered by Google App Engine
This is Rietveld 408576698