Scissor rect on drawinfo

src/gpu/GrGpu.cpp

 
 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "GrGpu.h"
@@ skipping 282 matching lines @@
                                                           4);
     }
 
     return fQuadIndexBuffer;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 bool GrGpu::setupClipAndFlushState(DrawType type,
                                    const GrDeviceCoordTexture* dstCopy,
-                                   GrDrawState::AutoRestoreEffects* are,
-                                   const SkRect* devBounds) {
-    GrDrawState::AutoRestoreStencil asr;
-    if (!fClipMaskManager.setupClipping(this->getClip(), are, &asr, devBounds)) {
+                                   const GrDrawTarget::DrawInfo& drawInfo,
+                                   GrDrawState::AutoRestoreEffects* are) {
+    DrawInfo modifiableDrawInfo = drawInfo;
+    GrDrawState::AutoRestoreStencil arStencil;

[bsalomon, 2014/10/27 19:41:23]

Here it's arStencil, but the param is named asStencil... the first kinda makes
sense to me, but asStencil doesn't.

+    if (!fClipMaskManager.setupClipping(this->getClip(),
+                                        &modifiableDrawInfo,
+                                        are,
+                                        &arStencil)) {
         return false;
     }
 
-    if (!this->flushGraphicsState(type, dstCopy)) {
+    if (!this->flushGraphicsState(modifiableDrawInfo, type, dstCopy)) {
         return false;
     }
 
     return true;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 void GrGpu::geometrySourceWillPush() {
     const GeometrySrcState& geoSrc = this->getGeomSrc();
@@ skipping 19 matching lines @@
 void GrGpu::geometrySourceWillPop(const GeometrySrcState& restoredState) {
     // if popping last entry then pops are unbalanced with pushes
     SkASSERT(fGeomPoolStateStack.count() > 1);
     fGeomPoolStateStack.pop_back();
 }
 
 void GrGpu::onDraw(const DrawInfo& info) {
     this->handleDirtyContext();
     GrDrawState::AutoRestoreEffects are;
     if (!this->setupClipAndFlushState(PrimTypeToDrawType(info.primitiveType()),
-                                      info.getDstCopy(), &are, info.getDevBounds())) {
+                                      info.getDstCopy(),

[bsalomon, 2014/10/27 19:41:23]

Need to pass dst copy separately when it's already on info?

+                                      info,
+                                      &are)) {
         return;
     }
     this->onGpuDraw(info);
 }
 
 void GrGpu::onStencilPath(const GrPath* path, SkPath::FillType fill) {
     this->handleDirtyContext();
 
+    GrDrawTarget::DrawInfo drawInfo;
     GrDrawState::AutoRestoreEffects are;
-    if (!this->setupClipAndFlushState(kStencilPath_DrawType, NULL, &are, NULL)) {
+    if (!this->setupClipAndFlushState(kStencilPath_DrawType,
+                                      NULL,
+                                      drawInfo,
+                                      &are)) {
         return;
     }
 
     this->pathRendering()->stencilPath(path, fill);
 }
 
 
 void GrGpu::onDrawPath(const GrPath* path, SkPath::FillType fill,
                        const GrDeviceCoordTexture* dstCopy) {
     this->handleDirtyContext();
 
     drawState()->setDefaultVertexAttribs();
 
+    GrDrawTarget::DrawInfo drawInfo;

[bsalomon, 2014/10/27 19:41:23]

Eek

     GrDrawState::AutoRestoreEffects are;
-    if (!this->setupClipAndFlushState(kDrawPath_DrawType, dstCopy, &are, NULL)) {
+    if (!this->setupClipAndFlushState(kDrawPath_DrawType,
+                                      dstCopy,
+                                      drawInfo,
+                                      &are)) {
         return;
     }
 
     this->pathRendering()->drawPath(path, fill);
 }
 
 void GrGpu::onDrawPaths(const GrPathRange* pathRange,
                         const uint32_t indices[], int count,
                         const float transforms[], PathTransformType transformsType,
                         SkPath::FillType fill, const GrDeviceCoordTexture* dstCopy) {
     this->handleDirtyContext();
 
     drawState()->setDefaultVertexAttribs();
 
+    GrDrawTarget::DrawInfo drawInfo;
     GrDrawState::AutoRestoreEffects are;
-    if (!this->setupClipAndFlushState(kDrawPaths_DrawType, dstCopy, &are, NULL)) {
+    if (!this->setupClipAndFlushState(kDrawPaths_DrawType,
+                                      dstCopy,
+                                      drawInfo,
+                                      &are)) {
         return;
     }
 
     pathRange->willDrawPaths(indices, count);
     this->pathRendering()->drawPaths(pathRange, indices, count, transforms, transformsType, fill);
 }
 
 void GrGpu::finalizeReservedVertices() {
     SkASSERT(fVertexPool);
     fVertexPool->unmap();
@@ skipping 124 matching lines @@
 }
 
 void GrGpu::releaseIndexArray() {
     // if index source was array, we stowed data in the pool
     const GeometrySrcState& geoSrc = this->getGeomSrc();
     SkASSERT(kArray_GeometrySrcType == geoSrc.fIndexSrc);
     size_t bytes = geoSrc.fIndexCount * sizeof(uint16_t);
     fIndexPool->putBack(bytes);
     --fIndexPoolUseCnt;
 }