HTMLImportLoader should talk directly to mojo::NetworkService

HTMLImportLoader should talk directly to mojo::NetworkService

This CL re-routes the loading pipeline for HTMLImportLoader directly to
mojo::NetworkService rather than through core/fetch, platform/network, and
WebURLLoader.

R=eseidel@chromium.org, esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/dcb24cc49fba8e1b54114622963acb95db1b34aa

[eseidel, 2014-10-24 21:50:06]

my eyes bleed.

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
File sky/engine/core/html/imports/HTMLImportLoader.h (right):

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
sky/engine/core/html/imports/HTMLImportLoader.h:109: void
OnReceivedResponse(mojo::URLResponsePtr response) override;
redundant

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
sky/engine/core/html/imports/HTMLImportLoader.h:115: State
startWritingAndParsing(mojo::URLResponsePtr response);
redundant

[eseidel, 2014-10-24 21:50:10]

lgtm

[esprehn, 2014-10-24 21:50:12]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2014-10-24 21:50:13]

lgtm

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
File sky/engine/core/html/imports/HTMLImportLoader.cpp (right):

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
sky/engine/core/html/imports/HTMLImportLoader.cpp:94: void
HTMLImportLoader::OnDataAvailable(const void* data, size_t length)
Why void* if we just cast to char* to use it?

https://codereview.chromium.org/678683004/diff/1/sky/engine/platform/fetcher/...
File sky/engine/platform/fetcher/MojoFetcher.cpp (right):

https://codereview.chromium.org/678683004/diff/1/sky/engine/platform/fetcher/...
sky/engine/platform/fetcher/MojoFetcher.cpp:16: : client_(client),
sigh, the comma at the end is really hard to catch.

[abarth-chromium, 2014-10-24 21:56:37]

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
File sky/engine/core/html/imports/HTMLImportLoader.cpp (right):

https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
sky/engine/core/html/imports/HTMLImportLoader.cpp:94: void
HTMLImportLoader::OnDataAvailable(const void* data, size_t length)
On 2014/10/24 at 21:50:12, esprehn wrote:
> Why void* if we just cast to char* to use it?

The code that declares this function doesn't know what the data represents.  It
could be characters or it could be binary image data.  In this series of CLs,
I'm going to push the pipe deeper and deeper into the system until its feeding
the UTF8 decoder directly.  At that point, it makes sense to take binary data
and get UChars out of it.

[esprehn, 2014-10-24 22:01:42]

On 2014/10/24 at 21:56:37, abarth wrote:
>
https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
> File sky/engine/core/html/imports/HTMLImportLoader.cpp (right):
> 
>
https://codereview.chromium.org/678683004/diff/1/sky/engine/core/html/imports...
> sky/engine/core/html/imports/HTMLImportLoader.cpp:94: void
HTMLImportLoader::OnDataAvailable(const void* data, size_t length)
> On 2014/10/24 at 21:50:12, esprehn wrote:
> > Why void* if we just cast to char* to use it?
> 
> The code that declares this function doesn't know what the data represents. 
It could be characters or it could be binary image data.  In this series of CLs,
I'm going to push the pipe deeper and deeper into the system until its feeding
the UTF8 decoder directly.  At that point, it makes sense to take binary data
and get UChars out of it.

What is length then? Isn't it the number of bytes? Char is a single byte, so it
makes sense to start off as a char* and then cast to bigger types and do math on
length when needed.

[abarth-chromium, 2014-10-24 22:05:47]

Committed patchset #2 (id:20001) manually as
dcb24cc49fba8e1b54114622963acb95db1b34aa.

[abarth-chromium, 2014-10-24 22:14:28]

On 2014/10/24 at 22:01:42, esprehn wrote:
> What is length then? Isn't it the number of bytes? Char is a single byte, so
it makes sense to start off as a char* and then cast to bigger types and do math
on length when needed.

Yes, sorry.  Number of bytes:

    virtual void OnDataAvailable(const void* data, size_t num_bytes) = 0;

I should have changed the variable name here too.  I'll fix the problem soon by
deleting this code and moving the pipe draining into the parser.

[abarth-chromium, 2014-10-25 01:24:32]

Should be fixed now.