Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: sky/engine/core/html/imports/HTMLImportLoader.cpp

Issue 678683004: HTMLImportLoader should talk directly to mojo::NetworkService (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address reviewer comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/imports/HTMLImportLoader.cpp
diff --git a/sky/engine/core/html/imports/HTMLImportLoader.cpp b/sky/engine/core/html/imports/HTMLImportLoader.cpp
index d0c326c3b916f7664f8e0f537a76cac6bd5545be..e75ede44c12b1dd9b555f36f8b45e8ab96f5bfc1 100644
--- a/sky/engine/core/html/imports/HTMLImportLoader.cpp
+++ b/sky/engine/core/html/imports/HTMLImportLoader.cpp
@@ -70,47 +70,43 @@ void HTMLImportLoader::clear()
m_document->cancelParsing();
m_document.clear();
}
+ m_fetcher.clear();
+ m_drainer.clear();
}
#endif
-void HTMLImportLoader::startLoading(const ResourcePtr<RawResource>& resource)
+void HTMLImportLoader::startLoading(const KURL& url)
{
- setResource(resource);
+ m_fetcher = adoptPtr(new MojoFetcher(this, url));
}
-void HTMLImportLoader::responseReceived(Resource* resource, const ResourceResponse& response)
+void HTMLImportLoader::OnReceivedResponse(mojo::URLResponsePtr response)
{
- // Resource may already have been loaded with the import loader
- // being added as a client later & now being notified. Fail early.
- if (resource->loadFailedOrCanceled() || response.httpStatusCode() >= 400) {
+ if (response->error || response->status_code >= 400) {
setState(StateError);
return;
}
- setState(startWritingAndParsing(response));
+ mojo::ScopedDataPipeConsumerHandle body = response->body.Pass();
+ setState(startWritingAndParsing(response.Pass()));
+ m_drainer = adoptPtr(new DataPipeDrainer(this, body.Pass()));
}
-void HTMLImportLoader::dataReceived(Resource*, const char* data, int length)
+void HTMLImportLoader::OnDataAvailable(const void* data, size_t length)
{
RefPtrWillBeRawPtr<DocumentWriter> protectingWriter(m_writer.get());
- m_writer->addData(data, length);
+ m_writer->addData(static_cast<const char*>(data), length);
}
-void HTMLImportLoader::notifyFinished(Resource* resource)
+void HTMLImportLoader::OnDataComplete()
{
- // The writer instance indicates that a part of the document can be already loaded.
- // We don't take such a case as an error because the partially-loaded document has been visible from script at this point.
- if (resource->loadFailedOrCanceled() && !m_writer) {
- setState(StateError);
- return;
- }
-
setState(finishWriting());
}
-HTMLImportLoader::State HTMLImportLoader::startWritingAndParsing(const ResourceResponse& response)
+HTMLImportLoader::State HTMLImportLoader::startWritingAndParsing(mojo::URLResponsePtr response)
{
ASSERT(!m_imports.isEmpty());
- DocumentInit init = DocumentInit(response.url(), 0, m_controller->master()->contextDocument(), m_controller)
+ KURL url(ParsedURLString, String::fromUTF8(response->url));
+ DocumentInit init = DocumentInit(url, 0, m_controller->master()->contextDocument(), m_controller)
.withRegistrationContext(m_controller->master()->registrationContext());
m_document = HTMLDocument::create(init);
m_writer = DocumentWriter::create(m_document.get());
@@ -167,8 +163,6 @@ void HTMLImportLoader::didFinishLoading()
for (size_t i = 0; i < m_imports.size(); ++i)
m_imports[i]->didFinishLoading();
- clearResource();
-
ASSERT(!m_document || !m_document->parsing());
}
« no previous file with comments | « sky/engine/core/html/imports/HTMLImportLoader.h ('k') | sky/engine/core/html/imports/HTMLImportsController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698