sky/engine/platform/BUILD.gn - Issue 678683004: HTMLImportLoader should talk directly to mojo::NetworkService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/platform/BUILD.gn

Issue 678683004: HTMLImportLoader should talk directly to mojo::NetworkService (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: address reviewer comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/platform/BUILD.gn

diff --git a/sky/engine/platform/BUILD.gn b/sky/engine/platform/BUILD.gn

index 2f2dd331307a0258d438fc26dd2e10ed9f9d7cf5..7a68a5a88a85cd6a37179f02fd9bf8f5f693d1a0 100644

--- a/sky/engine/platform/BUILD.gn

+++ b/sky/engine/platform/BUILD.gn

@@ -244,6 +244,8 @@ component("platform") {

"exported/linux/WebFontRenderStyle.cpp",

"fetcher/DataPipeDrainer.cpp",

"fetcher/DataPipeDrainer.h",

+ "fetcher/MojoFetcher.cpp",

+ "fetcher/MojoFetcher.h",

"fonts/AlternateFontFamily.h",

"fonts/Character.cpp",

"fonts/Character.h",

@@ -685,10 +687,12 @@ component("platform") {

"//third_party/libpng",

"//third_party/ots",

"//third_party/qcms",

- "//mojo/application",

+ "//mojo/common",

+ "//mojo/environment:chromium",

+ "//mojo/public/c/system:for_shared_library",

"//mojo/public/cpp/bindings",

"//mojo/public/cpp/utility",

- "//mojo/public/c/system:for_shared_library",

+ "//mojo/services/public/interfaces/network",

"//sky/engine/wtf",

"//sky/engine/platform/heap",

"//url",

« no previous file with comments | « sky/engine/core/html/imports/HTMLImportsController.cpp ('k') | sky/engine/platform/DEPS » ('j') | no next file with comments »