Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: sky/engine/core/html/imports/HTMLImportsController.cpp

Issue 678683004: HTMLImportLoader should talk directly to mojo::NetworkService (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address reviewer comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/imports/HTMLImportLoader.cpp ('k') | sky/engine/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/imports/HTMLImportsController.cpp
diff --git a/sky/engine/core/html/imports/HTMLImportsController.cpp b/sky/engine/core/html/imports/HTMLImportsController.cpp
index 57fc45a6cbd0ddc1d874d682978f2e05eb1c9a3e..2c3dd26b1eb0f6aa168b4e52943067b5add31fae 100644
--- a/sky/engine/core/html/imports/HTMLImportsController.cpp
+++ b/sky/engine/core/html/imports/HTMLImportsController.cpp
@@ -114,15 +114,11 @@ HTMLImportChild* HTMLImportsController::load(HTMLImport* parent, HTMLImportChild
return child;
}
- ResourcePtr<RawResource> resource = parent->document()->fetcher()->fetchImport(request);
- if (!resource)
- return 0;
-
HTMLImportLoader* loader = createLoader();
HTMLImportChild* child = createChild(request.url(), loader, parent, client);
// We set resource after the import tree is built since
// Resource::addClient() immediately calls back to feed the bytes when the resource is cached.
- loader->startLoading(resource);
+ loader->startLoading(request.url());
child->didStartLoading();
return child;
}
« no previous file with comments | « sky/engine/core/html/imports/HTMLImportLoader.cpp ('k') | sky/engine/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698