Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC)

Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC) (Closed)

Created:
9 years, 8 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, Louis

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/factory_test_tools.git@master

Visibility:
Public.

Description

gooftool: always process EC before BIOS (workaround for buggy EC) EC on some platform is still buggy. If we leave BBS selector to LPC, rebooting command will fail. User will end in frozen with "Rebooting" message. As a workaround, we should always process EC before BIOS. BUG=chrome-os-partner:854 TEST=gooftool --finalize --db_path DBPATH --upload_method none flashrom -V | grep Found # the output is SPI(BIOS), not LPC(EC). reboot # success on Z* Change-Id: I3f09b6e0f4a3017801b26b9c7dfa0bf1cc5050d2 R=yjlou@chromium.org,nsanders@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c4f91cb

Patch Set 1 #

Total comments: 3

Patch Set 2 : improve wpfw command #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	gft_report.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gft_wpfw.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gooftool	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Louis

http://codereview.chromium.org/6778007/diff/1/gooftool File gooftool (right): http://codereview.chromium.org/6778007/diff/1/gooftool#newcode315 gooftool:315: if EnableWriteProtect('ec') and EnableWriteProtect('bios'): hm... a risk here: if ...

9 years, 8 months ago (2011-03-30 09:28:59 UTC) #2

Hung-Te

9 years, 8 months ago (2011-03-30 09:40:09 UTC) #3

Nick Sanders

lgtm http://codereview.chromium.org/6778007/diff/1/gooftool File gooftool (right): http://codereview.chromium.org/6778007/diff/1/gooftool#newcode315 gooftool:315: if EnableWriteProtect('ec') and EnableWriteProtect('bios'): Probably just as well ...

9 years, 8 months ago (2011-03-30 09:40:43 UTC) #4

Louis

9 years, 8 months ago (2011-03-30 09:46:05 UTC) #5

Okay. LGTM.
On 2011/03/30 09:28:59, Louis wrote:
> http://codereview.chromium.org/6778007/diff/1/gooftool
> File gooftool (right):
> 
> http://codereview.chromium.org/6778007/diff/1/gooftool#newcode315
> gooftool:315: if EnableWriteProtect('ec') and EnableWriteProtect('bios'):
> hm... a risk here: if EnableWriteProtect('ec') is false, then
> EnableWriteProtect('bios') will not be executed.

Expand Messages | Collapse Messages