gft_wpfw.py - Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gft_wpfw.py

Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC) (Closed) Base URL: ssh://gitrw.chromium.org:9222/factory_test_tools.git@master

Patch Set: improve wpfw command Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gft_wpfw.py

diff --git a/gft_wpfw.py b/gft_wpfw.py

index 6480c9f0615edd5306b6c54fd3c0d0fa6a2ad60b..e113ed41309e3b41494a76f0e4c005f554e8173f 100755

--- a/gft_wpfw.py

+++ b/gft_wpfw.py

@@ -100,6 +100,11 @@ def EnableWriteProtect(target):

flashrom.disable_write_protect()

if not flashrom.verify_write_protect(layout, 'ro'):

ErrorDie('wpfw: not write-protected (modifiable status): ' + name)

+ # Always restore the target to BIOS(spi). Some platforms may fail to reboot if

+ # target is EC(lpc).

+ if target != flashrom.TARGET_BIOS:

+ flashrom.select_target(flashrom.TARGET_BIOS)

return True

« no previous file with comments | « gft_report.py ('k') | gooftool » ('j') | no next file with comments »