gft_report.py - Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gft_report.py

Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC) (Closed) Base URL: ssh://gitrw.chromium.org:9222/factory_test_tools.git@master

Patch Set: improve wpfw command Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gft_report.py

diff --git a/gft_report.py b/gft_report.py

index 0ca8739072a2a804518a228ff6d29dea4a35757d..0b100be95f2eabfcc589c36d08e9744fad56a0c0 100755

--- a/gft_report.py

+++ b/gft_report.py

@@ -207,8 +207,8 @@ def CreateReport(create_params,

# Firmware write protection status

wp_status_message = (

'main: %s\nec: %s' %

- (gft_common.SystemOutput('flashrom -p internal:bus=spi --wp-status'),

- gft_common.SystemOutput('flashrom -p internal:bus=lpc --wp-status')))

+ (gft_common.SystemOutput('flashrom -p internal:bus=lpc --wp-status'),

+ gft_common.SystemOutput('flashrom -p internal:bus=spi --wp-status')))

report['wp_status'] = wp_status_message.splitlines()

# TODO(hungte) we may also add these data in future:

« no previous file with comments | « no previous file | gft_wpfw.py » ('j') | no next file with comments »