Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 675693002: An API returning a Promise should not throw an exceptions [overload version] (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 2 months ago
Reviewers:
haraken, Jens Widell, jsbell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

An API returning a Promise should not throw an exceptions [overload version] [1] made such APIs return rejected Promises instead of throwing exceptions, but overloaded functions were not covered. This CL fixes the problem. 1: https://src.chromium.org/viewvc/blink?view=rev&revision=171450 BUG=359586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184291

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -67 lines) Patch
M LayoutTests/fast/js/Promise-bindings-check-exception.html View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/Promise-bindings-check-exception-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/cache-add-expected.txt View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterface.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/modules/TestPartialInterface3.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 8 chunks +95 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +74 lines, -57 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 3 chunks +71 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
yhirano
6 years, 2 months ago (2014-10-23 08:00:57 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-23 08:28:00 UTC) #3
Jens Widell
LGTM
6 years, 2 months ago (2014-10-23 08:34:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675693002/40001
6 years, 2 months ago (2014-10-23 09:02:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/14690)
6 years, 2 months ago (2014-10-23 09:15:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675693002/40001
6 years, 2 months ago (2014-10-23 09:19:19 UTC) #10
yhirano
It seems a recently added test (cache-add.html) is affected: jsbell@, can you take a look ...
6 years, 2 months ago (2014-10-23 11:57:00 UTC) #13
jsbell
On 2014/10/23 11:57:00, yhirano wrote: > It seems a recently added test (cache-add.html) is affected: ...
6 years, 2 months ago (2014-10-23 16:59:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675693002/60001
6 years, 2 months ago (2014-10-23 17:01:50 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 17:52:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 184291

Powered by Google App Engine
This is Rietveld 408576698