Source/core/testing/Internals.h - Issue 675693002: An API returning a Promise should not throw an exceptions [overload version]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/Internals.h

Issue 675693002: An API returning a Promise should not throw an exceptions [overload version] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/testing/Internals.h

diff --git a/Source/core/testing/Internals.h b/Source/core/testing/Internals.h

index 011665c7fecd4bb58b82a9ced40fc5a417ef0f2d..ce2f23286f7e0363df314253866748ffcacd0170 100644

--- a/Source/core/testing/Internals.h

+++ b/Source/core/testing/Internals.h

@@ -305,6 +305,9 @@ public:

ScriptPromise promiseCheck(ScriptState*, long, bool, const Dictionary&, const String&, const Vector<String>&, ExceptionState&);

ScriptPromise promiseCheckWithoutExceptionState(ScriptState*, const Dictionary&, const String&, const Vector<String>&);

ScriptPromise promiseCheckRange(ScriptState*, long);

+ ScriptPromise promiseCheckOverload(ScriptState*, Location*);

+ ScriptPromise promiseCheckOverload(ScriptState*, Document*);

+ ScriptPromise promiseCheckOverload(ScriptState*, Location*, long, long);

void trace(Visitor*);

« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »