Source/bindings/scripts/v8_interface.py - Issue 675693002: An API returning a Promise should not throw an exceptions [overload version]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 675693002: An API returning a Promise should not throw an exceptions [overload version] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 0b255a85d2875bd9a0fedd73bab997bff726b565..3c00e74e0e3a7e7e48622dca6fa37bfd80ff4ae6 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -563,6 +563,7 @@ def overloads_context(interface, overloads):

'measure_all_as': common_value(overloads, 'measure_as'), # [MeasureAs]

'minarg': lengths[0],

'per_context_enabled_function_all': common_value(overloads, 'per_context_enabled_function'), # [PerContextEnabled]

+ 'returns_promise_all': promise_overload_count > 0,

'runtime_enabled_function_all': common_value(overloads, 'runtime_enabled_function'), # [RuntimeEnabled]

'valid_arities': lengths

# Only need to report valid arities if there is a gap in the

« no previous file with comments | « LayoutTests/http/tests/serviceworker/cache-add-expected.txt ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »