Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 675693002: An API returning a Promise should not throw an exceptions [overload version] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/testing/Internals.h ('k') | Source/core/testing/Internals.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 2161 matching lines...) Expand 10 before | Expand all | Expand 10 after
2172 ScriptPromise Internals::promiseCheckWithoutExceptionState(ScriptState* scriptSt ate, const Dictionary& arg1, const String& arg2, const Vector<String>& arg3) 2172 ScriptPromise Internals::promiseCheckWithoutExceptionState(ScriptState* scriptSt ate, const Dictionary& arg1, const String& arg2, const Vector<String>& arg3)
2173 { 2173 {
2174 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne")); 2174 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne"));
2175 } 2175 }
2176 2176
2177 ScriptPromise Internals::promiseCheckRange(ScriptState* scriptState, long arg1) 2177 ScriptPromise Internals::promiseCheckRange(ScriptState* scriptState, long arg1)
2178 { 2178 {
2179 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne")); 2179 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne"));
2180 } 2180 }
2181 2181
2182 ScriptPromise Internals::promiseCheckOverload(ScriptState* scriptState, Location *)
2183 {
2184 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne"));
2185 }
2186
2187 ScriptPromise Internals::promiseCheckOverload(ScriptState* scriptState, Document *)
2188 {
2189 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne"));
2190 }
2191
2192 ScriptPromise Internals::promiseCheckOverload(ScriptState* scriptState, Location *, long, long)
2193 {
2194 return ScriptPromise::cast(scriptState, v8String(scriptState->isolate(), "do ne"));
2195 }
2196
2182 void Internals::trace(Visitor* visitor) 2197 void Internals::trace(Visitor* visitor)
2183 { 2198 {
2184 visitor->trace(m_runtimeFlags); 2199 visitor->trace(m_runtimeFlags);
2185 visitor->trace(m_profilers); 2200 visitor->trace(m_profilers);
2186 } 2201 }
2187 2202
2188 void Internals::setValueForUser(Element* element, const String& value) 2203 void Internals::setValueForUser(Element* element, const String& value)
2189 { 2204 {
2190 toHTMLInputElement(element)->setValueForUser(value); 2205 toHTMLInputElement(element)->setValueForUser(value);
2191 } 2206 }
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
2284 } 2299 }
2285 toHTMLPlugInElement(element)->setPlaceholder(DictionaryPluginPlaceholder::cr eate(element->document(), options)); 2300 toHTMLPlugInElement(element)->setPlaceholder(DictionaryPluginPlaceholder::cr eate(element->document(), options));
2286 } 2301 }
2287 2302
2288 Iterator* Internals::iterator(ScriptState* scriptState, ExceptionState& exceptio nState) 2303 Iterator* Internals::iterator(ScriptState* scriptState, ExceptionState& exceptio nState)
2289 { 2304 {
2290 return new InternalsIterator; 2305 return new InternalsIterator;
2291 } 2306 }
2292 2307
2293 } // namespace blink 2308 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/testing/Internals.h ('k') | Source/core/testing/Internals.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698