Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 673013002: Remove OTIFICATION_METRIC_EVENT_DURATION that no-one is observing (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Remove OTIFICATION_METRIC_EVENT_DURATION that no-one is observing BUG=None R=msw@chromium.org Committed: https://crrev.com/70aed720b11e12291f6cebf97200d1bad3d3ef6e Cr-Commit-Position: refs/heads/master@{#301112}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/metrics/metric_event_duration_details.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/metrics_handler.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
oshima
6 years, 2 months ago (2014-10-23 21:21:06 UTC) #1
msw
CC'ing John, who added this way-back-when. https://codereview.chromium.org/673013002/diff/1/chrome/browser/ui/webui/metrics_handler.cc File chrome/browser/ui/webui/metrics_handler.cc (left): https://codereview.chromium.org/673013002/diff/1/chrome/browser/ui/webui/metrics_handler.cc#oldcode97 chrome/browser/ui/webui/metrics_handler.cc:97: MetricEventDurationDetails details(event_name, This ...
6 years, 2 months ago (2014-10-23 21:26:43 UTC) #2
oshima
https://codereview.chromium.org/673013002/diff/1/chrome/browser/ui/webui/metrics_handler.cc File chrome/browser/ui/webui/metrics_handler.cc (left): https://codereview.chromium.org/673013002/diff/1/chrome/browser/ui/webui/metrics_handler.cc#oldcode97 chrome/browser/ui/webui/metrics_handler.cc:97: MetricEventDurationDetails details(event_name, On 2014/10/23 21:26:42, msw wrote: > This ...
6 years, 2 months ago (2014-10-23 21:42:39 UTC) #3
msw
lgtm, thanks!
6 years, 2 months ago (2014-10-23 21:54:56 UTC) #4
oshima
sky, would you mind reviwing as c/b/ owner?
6 years, 2 months ago (2014-10-24 00:46:06 UTC) #8
sky
LGTM
6 years, 2 months ago (2014-10-24 15:08:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673013002/20001
6 years, 2 months ago (2014-10-24 15:20:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 16:07:24 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:08:56 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/70aed720b11e12291f6cebf97200d1bad3d3ef6e
Cr-Commit-Position: refs/heads/master@{#301112}

Powered by Google App Engine
This is Rietveld 408576698