Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: chrome/browser/ui/webui/metrics_handler.cc

Issue 673013002: Remove OTIFICATION_METRIC_EVENT_DURATION that no-one is observing (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: remove details Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metric_event_duration_details.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/metrics_handler.cc
diff --git a/chrome/browser/ui/webui/metrics_handler.cc b/chrome/browser/ui/webui/metrics_handler.cc
index 99fb59292954a1784da0d3e8830a4fa5e1705350..58cc102b7bbc7645eb550daa567202cd627aba40 100644
--- a/chrome/browser/ui/webui/metrics_handler.cc
+++ b/chrome/browser/ui/webui/metrics_handler.cc
@@ -10,12 +10,9 @@
#include "base/metrics/histogram.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
-#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/metrics/metric_event_duration_details.h"
#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
#include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h"
#include "chrome/common/ntp_logging_events.h"
-#include "content/public/browser/notification_service.h"
#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
@@ -94,8 +91,6 @@ void MetricsHandler::HandleLogEventTime(const base::ListValue* args) {
base::TimeDelta duration =
base::TimeTicks::Now() - core_tab_helper->new_tab_start_time();
- MetricEventDurationDetails details(event_name,
- static_cast<int>(duration.InMilliseconds()));
if (event_name == "Tab.NewTabScriptStart") {
UMA_HISTOGRAM_TIMES("Tab.NewTabScriptStart", duration);
@@ -109,10 +104,6 @@ void MetricsHandler::HandleLogEventTime(const base::ListValue* args) {
} else {
NOTREACHED();
}
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_METRIC_EVENT_DURATION,
- content::Source<WebContents>(tab),
- content::Details<MetricEventDurationDetails>(&details));
}
void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {
« no previous file with comments | « chrome/browser/metrics/metric_event_duration_details.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698