Remove OTIFICATION_METRIC_EVENT_DURATION that no-one is observing

chrome/browser/ui/webui/metrics_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/metrics_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
-#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/metrics/metric_event_duration_details.h"
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h"
 #include "chrome/common/ntp_logging_events.h"
-#include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 
 using base::ListValue;
 using base::UserMetricsAction;
 using content::WebContents;
 
 MetricsHandler::MetricsHandler() {}
 MetricsHandler::~MetricsHandler() {}
@@ skipping 58 matching lines @@
   WebContents* tab = web_ui()->GetWebContents();
 
   // Not all new tab pages get timed. In those cases, we don't have a
   // new_tab_start_time_.
   CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab);
   if (core_tab_helper->new_tab_start_time().is_null())
     return;
 
   base::TimeDelta duration =
       base::TimeTicks::Now() - core_tab_helper->new_tab_start_time();
   MetricEventDurationDetails details(event_name,

[msw, 2014/10/23 21:26:42]

This is now unused and can be removed; the type isn't used elsewhere, so you can
also remove chrome/browser/metrics/metric_event_duration_details.h :D

[oshima, 2014/10/23 21:42:39]

Ah, makes sense. Done.

       static_cast<int>(duration.InMilliseconds()));
 
   if (event_name == "Tab.NewTabScriptStart") {
     UMA_HISTOGRAM_TIMES("Tab.NewTabScriptStart", duration);
   } else if (event_name == "Tab.NewTabDOMContentLoaded") {
     UMA_HISTOGRAM_TIMES("Tab.NewTabDOMContentLoaded", duration);
   } else if (event_name == "Tab.NewTabOnload") {
     UMA_HISTOGRAM_TIMES("Tab.NewTabOnload", duration);
     // The new tab page has finished loading; reset it.
     CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab);
     core_tab_helper->set_new_tab_start_time(base::TimeTicks());
   } else {
     NOTREACHED();
   }
-  content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_METRIC_EVENT_DURATION,
-      content::Source<WebContents>(tab),
-      content::Details<MetricEventDurationDetails>(&details));
 }
 
 void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {
 #if !defined(OS_ANDROID)
   // Android uses native UI for NTP.
   NTPUserDataLogger::GetOrCreateFromWebContents(
       web_ui()->GetWebContents())->LogEvent(NTP_MOUSEOVER);
 #endif  // !defined(OS_ANDROID)
 }