Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: chrome/browser/chrome_notification_types.h

Issue 673013002: Remove OTIFICATION_METRIC_EVENT_DURATION that no-one is observing (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: remove details Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metric_event_duration_details.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_ 5 #ifndef CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
6 #define CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_ 6 #define CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #if defined(ENABLE_EXTENSIONS) 10 #if defined(ENABLE_EXTENSIONS)
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 // the InfoBarService the InfoBar was added to. The details is a 135 // the InfoBarService the InfoBar was added to. The details is a
136 // Details<InfoBar::AddedDetails>. 136 // Details<InfoBar::AddedDetails>.
137 NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED, 137 NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
138 138
139 // This message is sent when an InfoBar is about to be removed from an 139 // This message is sent when an InfoBar is about to be removed from an
140 // InfoBarService. The source is a Source<InfoBarService> with a pointer to 140 // InfoBarService. The source is a Source<InfoBarService> with a pointer to
141 // the InfoBarService the InfoBar was removed from. The details is a 141 // the InfoBarService the InfoBar was removed from. The details is a
142 // Details<InfoBar::RemovedDetails>. 142 // Details<InfoBar::RemovedDetails>.
143 NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED, 143 NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED,
144 144
145 // Used to fire notifications about how long various events took to
146 // complete. E.g., this is used to get more fine grained timings from the
147 // new tab page. The source is a WebContents and the details is a
148 // MetricEventDurationDetails.
149 NOTIFICATION_METRIC_EVENT_DURATION,
150
151 #if defined(ENABLE_EXTENSIONS) 145 #if defined(ENABLE_EXTENSIONS)
152 // This notification is sent when extensions::TabHelper::SetExtensionApp is 146 // This notification is sent when extensions::TabHelper::SetExtensionApp is
153 // invoked. The source is the extensions::TabHelper SetExtensionApp was 147 // invoked. The source is the extensions::TabHelper SetExtensionApp was
154 // invoked on. 148 // invoked on.
155 NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED, 149 NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED,
156 #endif 150 #endif
157 151
158 // Tabs -------------------------------------------------------------------- 152 // Tabs --------------------------------------------------------------------
159 153
160 // Sent when a tab is added to a WebContentsDelegate. The source is the 154 // Sent when a tab is added to a WebContentsDelegate. The source is the
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 // Note:- 683 // Note:-
690 // Currently only Content and Chrome define and use notifications. 684 // Currently only Content and Chrome define and use notifications.
691 // Custom notifications not belonging to Content and Chrome should start 685 // Custom notifications not belonging to Content and Chrome should start
692 // from here. 686 // from here.
693 NOTIFICATION_CHROME_END, 687 NOTIFICATION_CHROME_END,
694 }; 688 };
695 689
696 } // namespace chrome 690 } // namespace chrome
697 691
698 #endif // CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_ 692 #endif // CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/metric_event_duration_details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698