Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 67156: Fix regression I introduced where Stop/Go button would toggle state instantly... (Closed)

Created:
11 years, 8 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix regression I introduced where Stop/Go button would toggle state instantly instead of having protections against accidental user actions while the mouse was hovering the button. I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple. BUG=9843 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13761

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -55 lines) Patch
M chrome/browser/browser.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M chrome/browser/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/go_button.h View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/views/go_button.cc View 4 chunks +12 lines, -32 lines 0 comments Download
M chrome/test/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
11 years, 8 months ago (2009-04-15 01:37:24 UTC) #1
Ben Goodger (Google)
OK
11 years, 8 months ago (2009-04-15 01:43:38 UTC) #2
willchan no longer on Chromium
http://codereview.chromium.org/67156/diff/1/4 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/67156/diff/1/4#newcode434 Line 434: is_loading ? GoButtonGtk::MODE_STOP : GoButtonGtk::MODE_GO, force); Did you ...
11 years, 8 months ago (2009-04-15 18:23:46 UTC) #3
Peter Kasting
11 years, 8 months ago (2009-04-15 18:25:34 UTC) #4
On 2009/04/15 18:23:46, willchan wrote:
> Did you update GoButtonGtk::ChangeMode()?  I don't see it in this changelist.

No, because I'm dumb.  Will do.

Powered by Google App Engine
This is Rietveld 408576698