Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 67156: Fix regression I introduced where Stop/Go button would toggle state instantly... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.h ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/browser_window_gtk.h" 5 #include "chrome/browser/gtk/browser_window_gtk.h"
6 6
7 #include <gdk/gdkkeysyms.h> 7 #include <gdk/gdkkeysyms.h>
8 8
9 #include "base/base_paths_linux.h" 9 #include "base/base_paths_linux.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 } 422 }
423 423
424 LocationBar* BrowserWindowGtk::GetLocationBar() const { 424 LocationBar* BrowserWindowGtk::GetLocationBar() const {
425 return toolbar_->GetLocationBar(); 425 return toolbar_->GetLocationBar();
426 } 426 }
427 427
428 void BrowserWindowGtk::SetFocusToLocationBar() { 428 void BrowserWindowGtk::SetFocusToLocationBar() {
429 GetLocationBar()->FocusLocation(); 429 GetLocationBar()->FocusLocation();
430 } 430 }
431 431
432 void BrowserWindowGtk::UpdateStopGoState(bool is_loading) { 432 void BrowserWindowGtk::UpdateStopGoState(bool is_loading, bool force) {
433 toolbar_->GetGoButton()->ChangeMode( 433 toolbar_->GetGoButton()->ChangeMode(
434 is_loading ? GoButtonGtk::MODE_STOP : GoButtonGtk::MODE_GO); 434 is_loading ? GoButtonGtk::MODE_STOP : GoButtonGtk::MODE_GO, force);
willchan no longer on Chromium 2009/04/15 18:23:46 Did you update GoButtonGtk::ChangeMode()? I don't
435 } 435 }
436 436
437 void BrowserWindowGtk::UpdateToolbar(TabContents* contents, 437 void BrowserWindowGtk::UpdateToolbar(TabContents* contents,
438 bool should_restore_state) { 438 bool should_restore_state) {
439 toolbar_->UpdateTabContents(contents, should_restore_state); 439 toolbar_->UpdateTabContents(contents, should_restore_state);
440 } 440 }
441 441
442 void BrowserWindowGtk::FocusToolbar() { 442 void BrowserWindowGtk::FocusToolbar() {
443 NOTIMPLEMENTED(); 443 NOTIMPLEMENTED();
444 } 444 }
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 } else { 679 } else {
680 browser_window->ExecuteBrowserCommand(command_id); 680 browser_window->ExecuteBrowserCommand(command_id);
681 } 681 }
682 682
683 return TRUE; 683 return TRUE;
684 } 684 }
685 685
686 void BrowserWindowGtk::ExecuteBrowserCommand(int id) { 686 void BrowserWindowGtk::ExecuteBrowserCommand(int id) {
687 browser_->ExecuteCommand(id); 687 browser_->ExecuteCommand(id);
688 } 688 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.h ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698