Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: chrome/browser/browser.h

Issue 67156: Fix regression I introduced where Stop/Go button would toggle state instantly... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | chrome/browser/gtk/browser_window_gtk.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSER_H_ 5 #ifndef CHROME_BROWSER_BROWSER_H_
6 #define CHROME_BROWSER_BROWSER_H_ 6 #define CHROME_BROWSER_BROWSER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 9
10 #include <set> 10 #include <set>
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 // Initialize state for all browser commands. 481 // Initialize state for all browser commands.
482 void InitCommandState(); 482 void InitCommandState();
483 483
484 // Update commands whose state depends on the tab's state. 484 // Update commands whose state depends on the tab's state.
485 void UpdateCommandsForTabState(); 485 void UpdateCommandsForTabState();
486 486
487 // Update commands whose state depends on whether the window is in fullscreen 487 // Update commands whose state depends on whether the window is in fullscreen
488 // mode. 488 // mode.
489 void UpdateCommandsForFullscreenMode(bool is_fullscreen); 489 void UpdateCommandsForFullscreenMode(bool is_fullscreen);
490 490
491 // Set the correct stop/go icon and update the Go and Stop command states. 491 // Ask the Stop/Go button to change its icon, and update the Go and Stop
492 // |is_loading| is true if the current TabContents is loading. 492 // command states. |is_loading| is true if the current TabContents is
493 void UpdateStopGoState(bool is_loading); 493 // loading. |force| is true if the button should change its icon immediately.
494 void UpdateStopGoState(bool is_loading, bool force);
494 495
495 // UI update coalescing and handling //////////////////////////////////////// 496 // UI update coalescing and handling ////////////////////////////////////////
496 497
497 // Asks the toolbar (and as such the location bar) to update its state to 498 // Asks the toolbar (and as such the location bar) to update its state to
498 // reflect the current tab's current URL, security state, etc. 499 // reflect the current tab's current URL, security state, etc.
499 // If |should_restore_state| is true, we're switching (back?) to this tab and 500 // If |should_restore_state| is true, we're switching (back?) to this tab and
500 // should restore any previous location bar state (such as user editing) as 501 // should restore any previous location bar state (such as user editing) as
501 // well. 502 // well.
502 void UpdateToolbar(bool should_restore_state); 503 void UpdateToolbar(bool should_restore_state);
503 504
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 // The browser idle task helps cleanup unused memory resources when idle. 725 // The browser idle task helps cleanup unused memory resources when idle.
725 scoped_ptr<BrowserIdleTimer> idle_task_; 726 scoped_ptr<BrowserIdleTimer> idle_task_;
726 727
727 // Keep track of the encoding auto detect pref. 728 // Keep track of the encoding auto detect pref.
728 BooleanPrefMember encoding_auto_detect_; 729 BooleanPrefMember encoding_auto_detect_;
729 730
730 DISALLOW_COPY_AND_ASSIGN(Browser); 731 DISALLOW_COPY_AND_ASSIGN(Browser);
731 }; 732 };
732 733
733 #endif // CHROME_BROWSER_BROWSER_H_ 734 #endif // CHROME_BROWSER_BROWSER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | chrome/browser/gtk/browser_window_gtk.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698