Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/browser/browser.cc

Issue 67156: Fix regression I introduced where Stop/Go button would toggle state instantly... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 13668)
+++ chrome/browser/browser.cc (working copy)
@@ -1584,7 +1584,7 @@
UpdateToolbar(true);
// Update stop/go state.
- UpdateStopGoState(new_contents->is_loading());
+ UpdateStopGoState(new_contents->is_loading(), true);
// Update commands to reflect current state.
UpdateCommandsForTabState();
@@ -1836,7 +1836,7 @@
window_->UpdateTitleBar();
if (source == GetSelectedTabContents()) {
- UpdateStopGoState(source->is_loading());
+ UpdateStopGoState(source->is_loading(), false);
if (GetStatusBubble())
GetStatusBubble()->SetStatus(GetSelectedTabContents()->GetStatusText());
}
@@ -2249,8 +2249,8 @@
command_updater_.UpdateCommandEnabled(IDC_ABOUT, show_main_ui);
}
-void Browser::UpdateStopGoState(bool is_loading) {
- window_->UpdateStopGoState(is_loading);
+void Browser::UpdateStopGoState(bool is_loading, bool force) {
+ window_->UpdateStopGoState(is_loading, force);
command_updater_.UpdateCommandEnabled(IDC_GO, !is_loading);
command_updater_.UpdateCommandEnabled(IDC_STOP, is_loading);
}

Powered by Google App Engine
This is Rietveld 408576698