sky/engine/bindings/core/v8/V8GCController.cpp - Issue 671173006: Remove lots of machinery related to inline event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8GCController.cpp

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/V8GCController.cpp

diff --git a/sky/engine/bindings/core/v8/V8GCController.cpp b/sky/engine/bindings/core/v8/V8GCController.cpp

index abf877fd49d864acaf731c2261deffa2d6be0e55..207af1ae848a9f14459f38b246a50f7d68dacdd3 100644

--- a/sky/engine/bindings/core/v8/V8GCController.cpp

+++ b/sky/engine/bindings/core/v8/V8GCController.cpp

@@ -62,8 +62,6 @@ static void addReferencesForNodeWithEventListeners(v8::Isolate* isolate, Node* n

EventListenerIterator iterator(node);

while (EventListener* listener = iterator.nextListener()) {

- if (listener->type() != EventListener::JSEventListenerType)

- continue;

V8AbstractEventListener* v8listener = static_cast<V8AbstractEventListener*>(listener);

if (!v8listener->hasExistingListenerObject())

continue;