Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 670853002: minidump: Migrate the rest of the tests to MinidumpWritableAtLocationDescriptor<>() (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

minidump: Migrate the rest of the tests to MinidumpWritableAtLocationDescriptor<>(). TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/20f95a2f5bb2500567328c2c1b3793f6a918cfac

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -176 lines) Patch
M minidump/minidump_context_writer_test.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M minidump/minidump_crashpad_info_writer_test.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 5 chunks +59 lines, -54 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 5 chunks +16 lines, -27 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 6 chunks +21 lines, -9 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M minidump/test/minidump_file_writer_test_util.h View 1 chunk +9 lines, -7 lines 0 comments Download
M minidump/test/minidump_file_writer_test_util.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M minidump/test/minidump_writable_test_util.h View 5 chunks +141 lines, -9 lines 0 comments Download
M minidump/test/minidump_writable_test_util.cc View 1 3 chunks +220 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-21 21:40:12 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/670853002/diff/1/minidump/test/minidump_writable_test_util.cc File minidump/test/minidump_writable_test_util.cc (right): https://codereview.chromium.org/670853002/diff/1/minidump/test/minidump_writable_test_util.cc#newcode93 minidump/test/minidump_writable_test_util.cc:93: if (misc->Length % 2 != 0) { Would ...
6 years, 2 months ago (2014-10-22 21:57:52 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-22 22:35:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
20f95a2f5bb2500567328c2c1b3793f6a918cfac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698