minidump: Migrate the rest of the tests to MinidumpWritableAtLocationDescriptor<>()

minidump/minidump_exception_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "minidump/minidump_exception_writer.h"
 
 #include <dbghelp.h>
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
 #include "gtest/gtest.h"
 #include "minidump/minidump_context.h"
 #include "minidump/minidump_context_writer.h"
 #include "minidump/minidump_extensions.h"
 #include "minidump/minidump_file_writer.h"
 #include "minidump/test/minidump_context_test_util.h"
 #include "minidump/test/minidump_file_writer_test_util.h"
+#include "minidump/test/minidump_writable_test_util.h"
 #include "util/file/string_file_writer.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 // This returns the MINIDUMP_EXCEPTION_STREAM stream in |exception_stream|.
 void GetExceptionStream(const std::string& file_contents,
                         const MINIDUMP_EXCEPTION_STREAM** exception_stream) {
   const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
   const size_t kExceptionStreamOffset =
       kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY);
   const size_t kContextOffset =
       kExceptionStreamOffset + sizeof(MINIDUMP_EXCEPTION_STREAM);
   const size_t kFileSize = kContextOffset + sizeof(MinidumpContextX86);
   ASSERT_EQ(file_contents.size(), kFileSize);
 
   const MINIDUMP_DIRECTORY* directory;
   const MINIDUMP_HEADER* header =
       MinidumpHeaderAtStart(file_contents, &directory);
   ASSERT_NO_FATAL_FAILURE(VerifyMinidumpHeader(header, 1, 0));
 
   ASSERT_EQ(kMinidumpStreamTypeException, directory[0].StreamType);
-  ASSERT_GE(directory[0].Location.DataSize, sizeof(MINIDUMP_EXCEPTION_STREAM));
-  ASSERT_EQ(kExceptionStreamOffset, directory[0].Location.Rva);
+  EXPECT_EQ(kExceptionStreamOffset, directory[0].Location.Rva);
 
-  *exception_stream = reinterpret_cast<const MINIDUMP_EXCEPTION_STREAM*>(
-      &file_contents[kExceptionStreamOffset]);
+  *exception_stream =
+      MinidumpWritableAtLocationDescriptor<MINIDUMP_EXCEPTION_STREAM>(
+          file_contents, directory[0].Location);
+  ASSERT_TRUE(exception_stream);
 }
 
 // The MINIDUMP_EXCEPTION_STREAMs |expected| and |observed| are compared against
 // each other using gtest assertions. The context will be recovered from
 // |file_contents| and stored in |context|.
 void ExpectExceptionStream(const MINIDUMP_EXCEPTION_STREAM* expected,
                            const MINIDUMP_EXCEPTION_STREAM* observed,
                            const std::string& file_contents,
                            const MinidumpContextX86** context) {
   EXPECT_EQ(expected->ThreadId, observed->ThreadId);
   EXPECT_EQ(0u, observed->__alignment);
   EXPECT_EQ(expected->ExceptionRecord.ExceptionCode,
             observed->ExceptionRecord.ExceptionCode);
   EXPECT_EQ(expected->ExceptionRecord.ExceptionFlags,
             observed->ExceptionRecord.ExceptionFlags);
   EXPECT_EQ(expected->ExceptionRecord.ExceptionRecord,
             observed->ExceptionRecord.ExceptionRecord);
   EXPECT_EQ(expected->ExceptionRecord.ExceptionAddress,
             observed->ExceptionRecord.ExceptionAddress);
   EXPECT_EQ(expected->ExceptionRecord.NumberParameters,
             observed->ExceptionRecord.NumberParameters);
   EXPECT_EQ(0u, observed->ExceptionRecord.__unusedAlignment);
   for (size_t index = 0;
        index < arraysize(observed->ExceptionRecord.ExceptionInformation);
        ++index) {
     EXPECT_EQ(expected->ExceptionRecord.ExceptionInformation[index],
               observed->ExceptionRecord.ExceptionInformation[index]);
   }
-  EXPECT_EQ(expected->ThreadContext.DataSize, observed->ThreadContext.DataSize);
-  ASSERT_NE(0u, observed->ThreadContext.DataSize);
-  ASSERT_NE(0u, observed->ThreadContext.Rva);
-  ASSERT_GE(file_contents.size(),
-            observed->ThreadContext.Rva + observed->ThreadContext.DataSize);
-  *context = reinterpret_cast<const MinidumpContextX86*>(
-      &file_contents[observed->ThreadContext.Rva]);
+  *context = MinidumpWritableAtLocationDescriptor<MinidumpContextX86>(
+      file_contents, observed->ThreadContext);
+  ASSERT_TRUE(context);
 }
 
 TEST(MinidumpExceptionWriter, Minimal) {
   MinidumpFileWriter minidump_file_writer;
   MinidumpExceptionWriter exception_writer;
 
   const uint32_t kSeed = 100;
 
   MinidumpContextX86Writer context_x86_writer;
   InitializeMinidumpContextX86(context_x86_writer.context(), kSeed);
@@ skipping 104 matching lines @@
   MinidumpExceptionWriter exception_writer;
   std::vector<uint64_t> exception_information(EXCEPTION_MAXIMUM_PARAMETERS + 1,
                                               0x5a5a5a5a5a5a5a5a);
   ASSERT_DEATH(exception_writer.SetExceptionInformation(exception_information),
                "kMaxParameters");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad