minidump: Migrate the rest of the tests to MinidumpWritableAtLocationDescriptor<>()

minidump/minidump_misc_info_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "minidump/minidump_misc_info_writer.h"
 
 #include <dbghelp.h>
 #include <string.h>
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "gtest/gtest.h"
 #include "minidump/minidump_file_writer.h"
 #include "minidump/test/minidump_file_writer_test_util.h"
+#include "minidump/test/minidump_writable_test_util.h"
 #include "util/file/string_file_writer.h"
 #include "util/stdlib/strlcpy.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 template <typename T>
 void GetMiscInfoStream(const std::string& file_contents, const T** misc_info) {
   const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
   const size_t kMiscInfoStreamOffset =
       kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY);
   const size_t kMiscInfoStreamSize = sizeof(T);
   const size_t kFileSize = kMiscInfoStreamOffset + kMiscInfoStreamSize;
 
   ASSERT_EQ(kFileSize, file_contents.size());
 
   const MINIDUMP_DIRECTORY* directory;
   const MINIDUMP_HEADER* header =
       MinidumpHeaderAtStart(file_contents, &directory);
   ASSERT_NO_FATAL_FAILURE(VerifyMinidumpHeader(header, 1, 0));
   ASSERT_TRUE(directory);
 
   ASSERT_EQ(kMinidumpStreamTypeMiscInfo, directory[0].StreamType);
-  ASSERT_EQ(kMiscInfoStreamSize, directory[0].Location.DataSize);
-  ASSERT_EQ(kMiscInfoStreamOffset, directory[0].Location.Rva);
+  EXPECT_EQ(kMiscInfoStreamOffset, directory[0].Location.Rva);
 
-  *misc_info =
-      reinterpret_cast<const T*>(&file_contents[kMiscInfoStreamOffset]);
-
-  ASSERT_EQ(kMiscInfoStreamSize, (*misc_info)->SizeOfInfo);
+  *misc_info = MinidumpWritableAtLocationDescriptor<T>(file_contents,
+                                                       directory[0].Location);
+  ASSERT_TRUE(misc_info);
 }
 
 void ExpectNULPaddedString16Equal(const char16* expected,
                                   const char16* observed,
                                   size_t size) {
   string16 expected_string(expected, size);
   string16 observed_string(observed, size);
   EXPECT_EQ(expected_string, observed_string);
 }
 
@@ skipping 539 matching lines @@
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
           arraysize(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad