Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: minidump/test/minidump_file_writer_test_util.cc

Issue 670853002: minidump: Migrate the rest of the tests to MinidumpWritableAtLocationDescriptor<>() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/test/minidump_file_writer_test_util.h ('k') | minidump/test/minidump_writable_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/test/minidump_file_writer_test_util.cc
diff --git a/minidump/test/minidump_file_writer_test_util.cc b/minidump/test/minidump_file_writer_test_util.cc
index e87c0997cdb0bf28c70771ce761c392d69da00d0..723e97d08338fb73f6872667e19cb23ebcb12e68 100644
--- a/minidump/test/minidump_file_writer_test_util.cc
+++ b/minidump/test/minidump_file_writer_test_util.cc
@@ -32,15 +32,6 @@ const MINIDUMP_HEADER* MinidumpHeaderAtStart(
file_contents, location_descriptor);
if (header) {
- if (header->Signature != MINIDUMP_SIGNATURE) {
- EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_SIGNATURE), header->Signature);
- return nullptr;
- }
- if (header->Version != MINIDUMP_VERSION) {
- EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_VERSION), header->Version);
- return nullptr;
- }
-
location_descriptor.DataSize =
header->NumberOfStreams * sizeof(MINIDUMP_DIRECTORY);
location_descriptor.Rva = header->StreamDirectoryRva;
@@ -57,8 +48,6 @@ void VerifyMinidumpHeader(const MINIDUMP_HEADER* header,
uint32_t streams,
uint32_t timestamp) {
ASSERT_TRUE(header);
- EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_SIGNATURE), header->Signature);
- EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_VERSION), header->Version);
ASSERT_EQ(streams, header->NumberOfStreams);
ASSERT_EQ(streams ? sizeof(MINIDUMP_HEADER) : 0u, header->StreamDirectoryRva);
EXPECT_EQ(0u, header->CheckSum);
« no previous file with comments | « minidump/test/minidump_file_writer_test_util.h ('k') | minidump/test/minidump_writable_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698