Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 669633002: Revert of TextRun::length() should return an unsigned (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, Rik, jbroman, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, danakj, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, mkwst+moarreviews_chromium.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of TextRun::length() should return an unsigned (patchset #2 id:190001 of https://codereview.chromium.org/652483002/) Reason for revert: breaks FindInPageControllerTest.FindInPageFormsTextAreas Original issue's description: > TextRun::length() should return an unsigned. > > Tightened int types to unsigned in TextRun to make it easier to reason about the code and in the process removed some casts and some ASSERTS that are no longer needed. > > Also made the getter type consistent with the corresponding member type for for consistency where applicable. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183934 TBR=eae@chromium.org,mlamouri@chromium.org,l.gombos@samsung.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M Source/core/rendering/svg/SVGTextMetrics.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/fonts/WidthCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/SimpleShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/TextRun.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/text/TextRunIterator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of TextRun::length() should return an unsigned
6 years, 2 months ago (2014-10-20 10:42:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669633002/1
6 years, 2 months ago (2014-10-20 10:43:35 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 10:44:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183970

Powered by Google App Engine
This is Rietveld 408576698