Source/platform/fonts/WidthCache.h - Issue 669633002: Revert of TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/WidthCache.h

Issue 669633002: Revert of TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/WidthCache.h

diff --git a/Source/platform/fonts/WidthCache.h b/Source/platform/fonts/WidthCache.h

index bcbd57c9f966afd6aa554f20c25dc5d24d4c4fa1..a377c9377d068d96266224552ab3b36009b50268 100644

--- a/Source/platform/fonts/WidthCache.h

+++ b/Source/platform/fonts/WidthCache.h

@@ -130,7 +130,7 @@

WidthCacheEntry* add(const TextRun& run, WidthCacheEntry entry)

{

- if (run.length() > SmallStringKey::capacity())

+ if (static_cast<unsigned>(run.length()) > SmallStringKey::capacity())

return 0;

if (m_countdown > 0) {

@@ -150,7 +150,7 @@

private:

WidthCacheEntry* addSlowCase(const TextRun& run, WidthCacheEntry entry)

{

- unsigned length = run.length();

+ int length = run.length();

bool isNewEntry;

WidthCacheEntry *value;

if (length == 1) {

« no previous file with comments | « Source/platform/fonts/Font.cpp ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.h » ('j') | no next file with comments »