Source/platform/fonts/shaping/SimpleShaper.cpp - Issue 669633002: Revert of TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.cpp

Issue 669633002: Revert of TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/shaping/SimpleShaper.cpp

diff --git a/Source/platform/fonts/shaping/SimpleShaper.cpp b/Source/platform/fonts/shaping/SimpleShaper.cpp

index 1578bae41d565f9fd8e79acac4a766ea9e6f8565..24be19b9ee933caae0e3af3b62499483fc314198 100644

--- a/Source/platform/fonts/shaping/SimpleShaper.cpp

+++ b/Source/platform/fonts/shaping/SimpleShaper.cpp

@@ -134,7 +134,7 @@

}

if (m_run.allowsTrailingExpansion()

- || (m_run.ltr() && charData.characterOffset + charData.clusterLength < m_run.length())

+ || (m_run.ltr() && charData.characterOffset + charData.clusterLength < static_cast<size_t>(m_run.length()))

|| (m_run.rtl() && charData.characterOffset)) {

m_expansion -= m_expansionPerOpportunity;

width += m_expansionPerOpportunity;

« no previous file with comments | « Source/platform/fonts/shaping/HarfBuzzShaper.cpp ('k') | Source/platform/text/TextRun.h » ('j') | no next file with comments »