Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669603008: Standardize usage of virtual/override/final in storage/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
kinuko
CC:
chromium-reviews, dcheng, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in storage/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=kinuko@chromium.org Committed: https://crrev.com/1a54c8dfd0e8425ff93b471a1dedf8ea246c0b33 Cr-Commit-Position: refs/heads/master@{#300448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -600 lines) Patch
M storage/browser/blob/blob_data_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job.h View 1 chunk +8 lines, -11 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/blob/local_file_stream_reader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.h View 1 chunk +8 lines, -9 lines 0 comments Download
M storage/browser/database/database_quota_client.h View 1 chunk +15 lines, -15 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.h View 1 chunk +55 lines, -69 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.h View 1 chunk +10 lines, -11 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.h View 1 chunk +6 lines, -7 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M storage/browser/fileapi/external_mount_points.h View 2 chunks +14 lines, -16 lines 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +6 lines, -8 lines 0 comments Download
M storage/browser/fileapi/file_system_file_stream_reader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/file_system_file_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_context.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.h View 1 chunk +62 lines, -62 lines 0 comments Download
M storage/browser/fileapi/file_system_quota_client.h View 1 chunk +15 lines, -15 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.h View 1 chunk +9 lines, -13 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_writer_delegate.h View 2 chunks +12 lines, -13 lines 0 comments Download
M storage/browser/fileapi/isolated_context.h View 2 chunks +14 lines, -16 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.h View 1 chunk +18 lines, -18 lines 0 comments Download
M storage/browser/fileapi/local_file_stream_writer.h View 1 chunk +6 lines, -5 lines 0 comments Download
M storage/browser/fileapi/local_file_util.h View 1 chunk +39 lines, -49 lines 0 comments Download
M storage/browser/fileapi/local_file_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/native_file_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.h View 1 chunk +39 lines, -49 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.h View 2 chunks +28 lines, -32 lines 0 comments Download
M storage/browser/fileapi/quota/quota_backend_impl.h View 1 chunk +13 lines, -20 lines 0 comments Download
M storage/browser/fileapi/remove_operation_delegate.h View 1 chunk +9 lines, -9 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.h View 1 chunk +6 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.h View 1 chunk +18 lines, -18 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.h View 2 chunks +11 lines, -15 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_isolated_origin_database.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.h View 2 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/sandbox_quota_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/transient_file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/quota/quota_manager.h View 2 chunks +7 lines, -9 lines 0 comments Download
M storage/browser/quota/quota_manager.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M storage/browser/quota/usage_tracker.h View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669603008/1
6 years, 2 months ago (2014-10-21 09:40:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:01:33 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:02:22 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1a54c8dfd0e8425ff93b471a1dedf8ea246c0b33
Cr-Commit-Position: refs/heads/master@{#300448}

Powered by Google App Engine
This is Rietveld 408576698