storage/browser/fileapi/sandbox_file_system_backend_delegate.cc - Issue 669603008: Standardize usage of virtual/override/final in storage/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/sandbox_file_system_backend_delegate.cc

Issue 669603008: Standardize usage of virtual/override/final in storage/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « storage/browser/fileapi/sandbox_file_system_backend_delegate.h ('k') | storage/browser/fileapi/sandbox_isolated_origin_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: storage/browser/fileapi/sandbox_file_system_backend_delegate.cc

diff --git a/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc b/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc

index d68ba2c3adac050ea1b96ddc52569135f6ec4714..9fb6b0edb56d2f9e3e9ef50392059a80ea8ea07e 100644

--- a/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc

+++ b/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc

@@ -92,13 +92,11 @@ class ObfuscatedOriginEnumerator

explicit ObfuscatedOriginEnumerator(ObfuscatedFileUtil* file_util) {

enum_.reset(file_util->CreateOriginEnumerator());

}

- virtual ~ObfuscatedOriginEnumerator() {}

+ ~ObfuscatedOriginEnumerator() override {}

- virtual GURL Next() override {

- return enum_->Next();

- }

+ GURL Next() override { return enum_->Next(); }

- virtual bool HasFileSystemType(FileSystemType type) const override {

+ bool HasFileSystemType(FileSystemType type) const override {

return enum_->HasTypeDirectory(

SandboxFileSystemBackendDelegate::GetTypeString(type));

}