Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: storage/browser/fileapi/copy_or_move_operation_delegate.cc

Issue 669603008: Standardize usage of virtual/override/final in storage/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/fileapi/copy_or_move_operation_delegate.cc
diff --git a/storage/browser/fileapi/copy_or_move_operation_delegate.cc b/storage/browser/fileapi/copy_or_move_operation_delegate.cc
index a1e212bec8502bfff62719d64a0ed76bc64c0997..5b1d7d2238597f81b7830647e6c8f8dc151e0790 100644
--- a/storage/browser/fileapi/copy_or_move_operation_delegate.cc
+++ b/storage/browser/fileapi/copy_or_move_operation_delegate.cc
@@ -60,7 +60,7 @@ class CopyOrMoveOnSameFileSystemImpl
file_progress_callback_(file_progress_callback) {
}
- virtual void Run(
+ void Run(
const CopyOrMoveOperationDelegate::StatusCallback& callback) override {
if (operation_type_ == CopyOrMoveOperationDelegate::OPERATION_MOVE) {
operation_runner_->MoveFileLocal(src_url_, dest_url_, option_, callback);
@@ -70,7 +70,7 @@ class CopyOrMoveOnSameFileSystemImpl
}
}
- virtual void Cancel() override {
+ void Cancel() override {
// We can do nothing for the copy/move operation on a local file system.
// Assuming the operation is quickly done, it should be ok to just wait
// for the completion.
@@ -113,7 +113,7 @@ class SnapshotCopyOrMoveImpl
weak_factory_(this) {
}
- virtual void Run(
+ void Run(
const CopyOrMoveOperationDelegate::StatusCallback& callback) override {
file_progress_callback_.Run(0);
operation_runner_->CreateSnapshotFile(
@@ -122,9 +122,7 @@ class SnapshotCopyOrMoveImpl
weak_factory_.GetWeakPtr(), callback));
}
- virtual void Cancel() override {
- cancel_requested_ = true;
- }
+ void Cancel() override { cancel_requested_ = true; }
private:
void RunAfterCreateSnapshot(
@@ -388,7 +386,7 @@ class StreamCopyOrMoveImpl
cancel_requested_(false),
weak_factory_(this) {}
- virtual void Run(
+ void Run(
const CopyOrMoveOperationDelegate::StatusCallback& callback) override {
// Reader can be created even if the entry does not exist or the entry is
// a directory. To check errors before destination file creation,
@@ -399,7 +397,7 @@ class StreamCopyOrMoveImpl
weak_factory_.GetWeakPtr(), callback));
}
- virtual void Cancel() override {
+ void Cancel() override {
cancel_requested_ = true;
if (copy_helper_)
copy_helper_->Cancel();
« no previous file with comments | « storage/browser/fileapi/copy_or_move_operation_delegate.h ('k') | storage/browser/fileapi/dragged_file_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698