storage/browser/fileapi/sandbox_origin_database.h - Issue 669603008: Standardize usage of virtual/override/final in storage/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/sandbox_origin_database.h

Issue 669603008: Standardize usage of virtual/override/final in storage/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « storage/browser/fileapi/sandbox_isolated_origin_database.h ('k') | storage/browser/fileapi/sandbox_prioritized_origin_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: storage/browser/fileapi/sandbox_origin_database.h

diff --git a/storage/browser/fileapi/sandbox_origin_database.h b/storage/browser/fileapi/sandbox_origin_database.h

index 3fef8d5257852c566fecd11dc002cce2ad520e14..30e66c929a34305f67f97964e228d4ff94a179e1 100644

--- a/storage/browser/fileapi/sandbox_origin_database.h

+++ b/storage/browser/fileapi/sandbox_origin_database.h

@@ -33,15 +33,15 @@ class STORAGE_EXPORT_PRIVATE SandboxOriginDatabase

// at a given time.

SandboxOriginDatabase(const base::FilePath& file_system_directory,

leveldb::Env* env_override);

- virtual ~SandboxOriginDatabase();

+ ~SandboxOriginDatabase() override;

// SandboxOriginDatabaseInterface overrides.

- virtual bool HasOriginPath(const std::string& origin) override;

- virtual bool GetPathForOrigin(const std::string& origin,

- base::FilePath* directory) override;

- virtual bool RemovePathForOrigin(const std::string& origin) override;

- virtual bool ListAllOrigins(std::vector<OriginRecord>* origins) override;

- virtual void DropDatabase() override;

+ bool HasOriginPath(const std::string& origin) override;

+ bool GetPathForOrigin(const std::string& origin,

+ base::FilePath* directory) override;

+ bool RemovePathForOrigin(const std::string& origin) override;

+ bool ListAllOrigins(std::vector<OriginRecord>* origins) override;

+ void DropDatabase() override;

base::FilePath GetDatabasePath() const;

void RemoveDatabase();