Remove isSyncDatabase in WebDatabaseObserver [3/3]

Remove isSyncDatabase in WebDatabaseObserver [3/3]

Final clean-up for methods with isSyncDatabase parameter.

[1] https://codereview.chromium.org/660873004/
[2] https://codereview.chromium.org/666333002/
[3] THIS PATCH

BUG=428254
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184779

[rtakacs, 2014-10-22 09:27:26]

rtakacs.u-szeged@partner.samsung.com changed reviewers:
+ abarth@chromium.org, kinuko@google.com

[rtakacs, 2014-10-22 15:28:32]

The patch (outside Blink) that depends on this modification is at
https://codereview.chromium.org/666333002/

[kinuko, 2014-10-23 03:26:17]

The change itself looks good if this doesn't break build.  Could you run try
bots before asking for review so that reviewers can easily know it doesn't break
build?

[rtakacs, 2014-10-23 07:55:34]

On 2014/10/23 03:26:17, kinuko (slow to respond) wrote:
> The change itself looks good if this doesn't break build.  Could you run try
> bots before asking for review so that reviewers can easily know it doesn't
break
> build?

Of course! But, I'm afraid the bots will be red because the patch is separated
(one is at Blink side, and the other is at the outside).
WebDatabaseObserverImpl class (outside Blink) inherits from this
WebDatabaseObserver class (inside Blink).

I have a build with these patches and everithing seems to be ok.

[rtakacs, 2014-10-23 08:05:21]

On 2014/10/23 07:55:34, rtakacs wrote:
> On 2014/10/23 03:26:17, kinuko (slow to respond) wrote:
> > The change itself looks good if this doesn't break build.  Could you run try
> > bots before asking for review so that reviewers can easily know it doesn't
> break
> > build?
> 
> Of course! But, I'm afraid the bots will be red because the patch is separated
> (one is at Blink side, and the other is at the outside).
> WebDatabaseObserverImpl class (outside Blink) inherits from this
> WebDatabaseObserver class (inside Blink).
> 
> I have a build with these patches and everithing seems to be ok.

This is my first separated patch.
I think these patches shoud be landed ~at the same time. (Otherwise will cause a
nice build error who pull the blink and have only the one patch of these)

[kinuko, 2014-10-23 16:24:30]

On 2014/10/23 08:05:21, rtakacs wrote:
> On 2014/10/23 07:55:34, rtakacs wrote:
> > On 2014/10/23 03:26:17, kinuko (slow to respond) wrote:
> > > The change itself looks good if this doesn't break build.  Could you run
try
> > > bots before asking for review so that reviewers can easily know it doesn't
> > break
> > > build?
> > 
> > Of course! But, I'm afraid the bots will be red because the patch is
separated
> > (one is at Blink side, and the other is at the outside).
> > WebDatabaseObserverImpl class (outside Blink) inherits from this
> > WebDatabaseObserver class (inside Blink).
> > 
> > I have a build with these patches and everithing seems to be ok.
> 
> This is my first separated patch.
> I think these patches shoud be landed ~at the same time. (Otherwise will cause
a
> nice build error who pull the blink and have only the one patch of these)

Unfortunately the two patches in two repositories cannot land the same time, so
you'll need to make either one of the patches compilable without the other one.
One of the common ways is 1. add duplicated new methods that have default impl
to call old methods with FIXME comment (to note that later they should be
cleaned up) in blink, 2. override the new methods in chromium, and 3. cleanup
the duplicated old methods in blink.

[rtakacs, 2014-10-24 20:55:04]

On 2014/10/23 16:24:30, kinuko (slow to respond) wrote:
> On 2014/10/23 08:05:21, rtakacs wrote:
> > On 2014/10/23 07:55:34, rtakacs wrote:
> > > On 2014/10/23 03:26:17, kinuko (slow to respond) wrote:
> > > > The change itself looks good if this doesn't break build.  Could you run
> try
> > > > bots before asking for review so that reviewers can easily know it
doesn't
> > > break
> > > > build?
> > > 
> > > Of course! But, I'm afraid the bots will be red because the patch is
> separated
> > > (one is at Blink side, and the other is at the outside).
> > > WebDatabaseObserverImpl class (outside Blink) inherits from this
> > > WebDatabaseObserver class (inside Blink).
> > > 
> > > I have a build with these patches and everithing seems to be ok.
> > 
> > This is my first separated patch.
> > I think these patches shoud be landed ~at the same time. (Otherwise will
cause
> a
> > nice build error who pull the blink and have only the one patch of these)
> 
> Unfortunately the two patches in two repositories cannot land the same time,
so
> you'll need to make either one of the patches compilable without the other
one.
> One of the common ways is 1. add duplicated new methods that have default impl
> to call old methods with FIXME comment (to note that later they should be
> cleaned up) in blink, 2. override the new methods in chromium, and 3. cleanup
> the duplicated old methods in blink.

Thanks the tips!
I've a bug for duplicate the methods here:
https://codereview.chromium.org/660873004/

[kinuko, 2014-10-27 06:34:13]

On 2014/10/24 20:55:04, rtakacs wrote:
> On 2014/10/23 16:24:30, kinuko (slow to respond) wrote:
> > On 2014/10/23 08:05:21, rtakacs wrote:
> > > On 2014/10/23 07:55:34, rtakacs wrote:
> > > > On 2014/10/23 03:26:17, kinuko (slow to respond) wrote:
> > > > > The change itself looks good if this doesn't break build.  Could you
run
> > try
> > > > > bots before asking for review so that reviewers can easily know it
> doesn't
> > > > break
> > > > > build?
> > > > 
> > > > Of course! But, I'm afraid the bots will be red because the patch is
> > separated
> > > > (one is at Blink side, and the other is at the outside).
> > > > WebDatabaseObserverImpl class (outside Blink) inherits from this
> > > > WebDatabaseObserver class (inside Blink).
> > > > 
> > > > I have a build with these patches and everithing seems to be ok.
> > > 
> > > This is my first separated patch.
> > > I think these patches shoud be landed ~at the same time. (Otherwise will
> cause
> > a
> > > nice build error who pull the blink and have only the one patch of these)
> > 
> > Unfortunately the two patches in two repositories cannot land the same time,
> so
> > you'll need to make either one of the patches compilable without the other
> one.
> > One of the common ways is 1. add duplicated new methods that have default
impl
> > to call old methods with FIXME comment (to note that later they should be
> > cleaned up) in blink, 2. override the new methods in chromium, and 3.
cleanup
> > the duplicated old methods in blink.
> 
> Thanks the tips!
> I've a bug for duplicate the methods here:
> https://codereview.chromium.org/660873004/

Thanks.  Btw as I wrote in the other bug please don't send reviews to my google
account but to my chromium one.  Also afaik Adam doesn't do much blink review
these days, I think you'd better pick another reviewer from public/OWNERS (e.g.
dcheng@, jochen@ etc)

[rtakacs, 2014-10-28 10:44:40]

rtakacs.u-szeged@partner.samsung.com changed reviewers:
+ darin@chromium.org, mkwst@chromium.org

[rtakacs, 2014-10-28 10:44:41]

This patch is the final clean-up for isSyncDabase that depends on:

1st patch: [blink side] https://codereview.chromium.org/660873004/
2nd patch: [chromium side] https://codereview.chromium.org/666333002/

[Mike West, 2014-11-02 13:49:09]

LGTM.

[rtakacs, 2014-11-02 20:14:03]

The CQ bit was checked by rtakacs.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-11-02 20:14:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669063002/60001

[commit-bot: I haz the power, 2014-11-02 21:16:24]

Committed patchset #4 (id:60001) as 184779